Skip to content

bugfix: updated regex and split condition #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjaincertinia2025 merged 3 commits into from
Oct 15, 2025
Merged

bugfix: updated regex and split condition #13

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d894584
bugfix: updated regex and split condition
adawercertinia Oct 9, 2025
74d272a
updated changelog file
adawercertinia Oct 9, 2025
32bbd17
Resolved code review comment
adawercertinia Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

---

## \[Unreleased\]

### Fixed

* Enhanced the regex to be case-insensitive and to support `.` in repository names, enabling correct extraction of the repository name from SSH URLs in baseline scan.

## \[1.1.1\] \- 2025-09-26

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions output/output.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ func DisplayOutput(finalResult *finding.Output, scanTime *ScanTime) {
*/
func extractRepoNameFromURL(url string) string {
if url != "" {
findRepoNameRegexp := regexp.MustCompile(`[a-z0-9-]+/[a-z0-9-_]+\.git$`)
findRepoNameRegexp := regexp.MustCompile(`(?i)[a-z0-9-]+/[a-z0-9-_.]+\.git$`)
Copy link
Copy Markdown
Collaborator

@ssonicertinia ssonicertinia Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
findRepoNameRegexp := regexp.MustCompile(`(?i)[a-z0-9-]+/[a-z0-9-_.]+\.git$`)
findRepoNameRegexp := regexp.MustCompile(`(?i)[a-z0-9-_.]+/[a-z0-9-_.]+\.git$`)

Copy link
Copy Markdown
Collaborator Author

@adawercertinia adawercertinia Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regex updated.

match := findRepoNameRegexp.FindStringSubmatch(url)
if len(match) > 0 {
parts := strings.Split(match[0], ".")
parts := strings.Split(match[0], ".git")
if len(parts) > 1 {
return parts[0]
}
Expand Down
Loading