feat: time validation using accumulator contract #556
+6,724
−1,513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified EthRpc to be ChainInclusion and only return timestamp and root cid from chain. this required moving a decent amount of logic around parsing chain info/validation from service to validation crate.
This is mostly an example and requires figuring out the chain ID information and time event format, as well as passing in URLs via CLI flags, but demonstrates how the client could be hooked up using the refactored trait. It would also require some modifications to the exports in the hoku sdk to work (e.g. Address, HttpClient, FvmQueryHeight).
stbrody
force-pushed
the
refactor/modify-eth-rpc-trait-for-hoku
branch
from
70fb322 to
b5c388b
Compare
Base automatically changed from
refactor/modify-eth-rpc-trait-for-hoku
to
main
October 22, 2024 17:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft/example targeting #550 to validate time events using the accumulator contract and new time event format. Access to contract/proof taken from feat/time-event-validation-on-hoku.