Skip to content

s3: tests for wildcard support in conditional read #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+31 −0
Open

s3: tests for wildcard support in conditional read #681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions s3tests_boto3/functional/test_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3101,6 +3101,37 @@ def test_get_object_ifunmodifiedsince_failed():
body = _get_body(response)
assert body == 'bar'

def test_get_object_ifmatch_wildcard():
bucket_name = get_new_bucket()
client = get_client()
response = client.put_object(Bucket=bucket_name, Key='foo', Body='bar')
response = client.get_object(Bucket=bucket_name, Key='foo', IfMatch='*')
body = _get_body(response)
assert body == 'bar'

def test_get_object_ifnonematch_wildcard():
bucket_name = get_new_bucket()
client = get_client()
response = client.put_object(Bucket=bucket_name, Key='foo', Body='bar')
etag = response['ETag']

e = assert_raises(ClientError, client.get_object, Bucket=bucket_name, Key='foo', IfNoneMatch='*')
status, error_code = _get_status_and_error_code(e.response)
assert status == 304
assert e.response['Error']['Message'] == 'Not Modified'
assert e.response['ResponseMetadata']['HTTPHeaders']['etag'] == etag

def test_get_object_ifmatch_ifnonematch_wildcard():
bucket_name = get_new_bucket()
client = get_client()
response = client.put_object(Bucket=bucket_name, Key='foo', Body='bar')
etag = response['ETag']

e = assert_raises(ClientError, client.get_object, Bucket=bucket_name, Key='foo', IfMatch='*', IfNoneMatch='*')
status, error_code = _get_status_and_error_code(e.response)
assert status == 304
assert e.response['Error']['Message'] == 'Not Modified'
assert e.response['ResponseMetadata']['HTTPHeaders']['etag'] == etag

@pytest.mark.fails_on_aws
def test_put_object_ifmatch_good():
Expand Down