Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes gRPC-facing error message wording by using the human-readable phrase “network mask” instead of the proto field name “network_mask”, and updates the related tests to match.
Changes:
- Update
control/grpc.pyerror strings to say “network mask” in subnet/parameter validation failures. - Update
tests/test_auto_listeners.pyassertions to match the revised error messages.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
control/grpc.py |
Adjusts user-visible error messages for network mask validation and missing-parameter cases. |
tests/test_auto_listeners.py |
Updates caplog-based assertions to expect the new wording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
VallariAg
force-pushed
the
network-mask-log-fix
branch
from
e57f87c to
a5f69e9
Compare
Use "network mask" in error message instead of "network_mask". Fixes: ceph#1832 (comment) Signed-off-by: Vallari Agrawal <val.agl002@gmail.com> (cherry picked from commit e737040)
VallariAg
force-pushed
the
network-mask-log-fix
branch
from
a5f69e9 to
d769ba0
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gbregman
approved these changes
Mar 25, 2026
gbregman
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use "network mask" in error message instead
of "network_mask".
Fixes: #1832 (comment)
(cherry picked from commit e737040)