Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph_config: add support config remove (backport #7505) #7519

Merged
merged 1 commit into from
Mar 18, 2024
Merged

ceph_config: add support config remove (backport #7505) #7519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions library/ceph_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,24 @@ def set_option(module,
return rc, cmd, out.strip(), err


def rm_option(module,
who,
option,
container_image=None):

args = []
args.extend([who, option])

cmd = generate_cmd(sub_cmd=['config', 'rm'],
args=args,
cluster=module.params.get('cluster'),
container_image=container_image)

rc, out, err = module.run_command(cmd)

return rc, cmd, out.strip(), err


def get_config_dump(module, container_image=None):
cmd = generate_cmd(sub_cmd=['config', 'dump', '--format', 'json'],
args=[],
Expand All @@ -126,7 +144,7 @@ def main() -> None:
module = AnsibleModule(
argument_spec=dict(
who=dict(type='str', required=True),
action=dict(type='str', required=False, choices=['get', 'set'], default='set'),
action=dict(type='str', required=False, choices=['get', 'set', 'rm'], default='set'),
option=dict(type='str', required=True),
value=dict(type='str', required=False),
fsid=dict(type='str', required=False),
Expand Down Expand Up @@ -170,12 +188,16 @@ def main() -> None:
else:
rc, cmd, out, err = set_option(module, who, option, value, container_image=container_image)
changed = True
else:
elif action == 'get':
if current_value is None:
out = ''
err = 'No value found for who={} option={}'.format(who, option)
else:
out = current_value
elif action == 'rm':
if current_value:
rc, cmd, out, err = rm_option(module, who, option, container_image=container_image)
changed = True

exit_module(module=module, out=out, rc=rc,
cmd=cmd, err=err, startd=startd,
Expand Down
Loading