Loans: Support for benchmarking prices #1372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MaxCollectionSize
associated type that is only used underruntime-benchmarks
.By now, I think always using the maximum size of a price collection in benchmarks is ok. In comparison with the work done in
portfolio_valuation
over eachActiveLoan
, deserializing once a small or a big vector of prices should not affect too much the final value.If in the future, we need to struggle more with the benchmarks, we can add this as a variable parameter.
Associated to #1279