word level diff #15
Open
word level diff #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Is viewType=2 still supported? The code tends to default to 0 if we use 2. See https://github.com/cemerick/jsdifflib/blob/master/diffview.js#L54 |
Goodwine
reviewed
Jun 12, 2017
| @@ -51,7 +51,8 @@ diffview = { | |||
| var baseTextName = params.baseTextName ? params.baseTextName : "Base Text"; | |||
| var newTextName = params.newTextName ? params.newTextName : "New Text"; | |||
| var contextSize = params.contextSize; | |||
| var inline = (params.viewType == 0 || params.viewType == 1) ? params.viewType : 0; | |||
| var inline = (params.viewType == 0 || params.viewType >= 1) ? params.viewType : 0; | |||
There was a problem hiding this comment.
I think you should update params.viewType to use a 1 instead of params.viewType.
Also I think it would look better if it instead did this (depending on whether viewType is used in more places or not(?):
var inline = params.viewType ? 1 : 0;
|
I encountered such a problem that in those places where characters have changed, it draws lines without spaces like "destination10.0.1.96" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a quick hack to support word level diff with viewType = 2 param.
Please see http://moniwiki.kldp.net/diff.html