Repository navigation
Conversation
No acceptance job ran on this branch, so the devstack FeeHandler assertions were untested. op-geth is the only L2 EL here with Celo's changes; the devstack skips Karst chains on it, so only tests pinned up to Jovian run.
Upstream kona re-executes a Celo block with a user transaction to a different output root, so the ZK game is never proven, and tests/proofs/zk runs past the 30m package timeout on the single-node op-geth job.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the rebase onto op-node/v1.19.9 no op-acceptance-tests job runs in CI: upstream removed its op-geth variants and we disable the op-reth and kona ones, which run binaries without Celo's changes. This adds
memory-all-opn-op-gethback, the job celo-rebase-18 had, and makesci-gatewait for it. It restores less than the name suggests, because the devstack now skips every chain that schedules Karst when the EL is op-geth, and Karst is the default fork.What that means in practice, from a local run of seven test directories on op-geth: 7 tests passed and 24 skipped, every skip from the guard in
op-devstack/sysgo/deployer.go:546-555. The Ecotone FeeHandler assertion (op-acceptance-tests/tests/ecotone/fees_test.go) runs and passes. The Fjord one from #412 skips, and so do all twelvebase/conductortests. A green run of this job says the Jovian-and-older tests pass on Celo's op-geth and little more.Full coverage needs celo-reth as the test EL, tracked in celo-org/celo-blockchain-planning#1462. I decided against making the devstack default to Jovian for op-geth: that's fork-only test plumbing for an EL we're retiring. Karl raised the gap on #541 (#541 (comment)).
The first CI run (39 minutes, 274 results: 46 passed, 217 skipped, 11 failed) failed on upstream's ZK proposer, which Celo doesn't run, so the second commit skips those tests:
TestZKDisputeGameWithdrawalintests/proofs/super:kona-sp1-proposerre-executes the block holding the withdrawal transaction and gets a different output root than Celo's op-geth ("Failed to validate L2 block build(deps-dev): bump semver from 5.7.1 to 5.7.2 #33 with claimed output root …"), so the game is never proven. Skipped withgt.Skip, like the fork's other fault-proof skips.tests/proofs/zk: on one node the package runs serially and passes the 30-minute package timeout; 15 tests passed, one was cut off and nine never started. Skipped as a whole through aTestMainin a newcelo_test.go, so nothing in the upstream files changes. Its tests then don't show up as skipped in the report; the package prints one line saying why.Everything that passed locally passed in CI,
proofs/cannon_konaincluded, and the Ecotone FeeHandler test passed while the Fjord one skipped, as expected.For review:
rust-kona-binariesandrust-op-reth-binarydirectly, sincerust-binaries-for-sysgois disabled and the job exits early unlessop-rethandop-reth-sdm-fixtureexist.celo-org/2xlargenode (the job definition on this branch ignoresparallelism) and blocks every non-docs push. Without the ZK tests it should take well under the 39 minutes of the first run; the second run will give the number.The ci-config-reviewer pass found nothing blocking; I dropped the
discordcontext it flagged as unused. The merged config passescircleci config validateandcircleci config process..circleci/scripts/test-decision-tree.shdoesn't run under macOS bash 3.2, so that check is unrun; this change doesn't touch routing. I didn't run the Go review agent on the two-line skip commit. The base ispalango/celo-rebase-19becausecelo-rebase-19isn't published yet.