Add optional Celo fields for strict deploy-config parsing #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezdac
force-pushed
the
ezdac/fix-migration-config-parsing
branch
from
3aa7a1f to
8f302e7
Compare
palango
reviewed
Mar 14, 2025
palango
approved these changes
Mar 14, 2025
palango
force-pushed
the
ezdac/fix-migration-config-parsing
branch
from
0cae260 to
fe3a8c2
Compare
seolaoh
reviewed
Mar 14, 2025
seolaoh
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error we got during the dry-run, where our two added deploy-config fields
caused the strict json parsing of the
DeployConfigto fail, because the fields where not defined in the struct.The fields are not used currently in our go-code, so they are mainly added to make the strict parsing pass.