Add Prometheus metrics for AltDA failover in Batcher #361
Conversation
|
@jcortejoso @alvarof2 @gastonponti Any metrics besides those implemented that would be helpful for you? |
There was a problem hiding this comment.
Looks good!
I would record the batch-send success at a different location (see comment).
In terms of additional metrics,
maybe the actual number of bytes sent to the DA-proxy would be interesting,
so the cumulative sum of the http-body size in the setInput and setInputWithCommit, but only if the proxy returns a 200.
op-batcher/batcher/driver.go
Outdated
| @@ -863,6 +863,7 @@ func (l *BatchSubmitter) sendTransaction(txdata txData, queue *txmgr.Queue[txRef | |||
| } | |||
| // if Alt DA is enabled we post the txdata to the DA Provider and replace it with the commitment. | |||
| l.publishToAltDAAndL1(txdata, queue, receiptsCh, daGroup) | |||
| l.Metr.RecordBatchDaType(txdata.daType.Name()) | |||
There was a problem hiding this comment.
the publishToAltDAAndL1() spawns a goroutine that in turn calls the sendTx, but only if the AltDA input can be set correctly.
If you call this here, you get a "confirmation" for sending the tx, even though you could have aborted before the send and recorded a "failedDARequest".
I think I would only add one Metr.RecordBatchDaType call in general and rather do that at the end of the sendTx(), but only if the passed in isCancel==false
There was a problem hiding this comment.
@ezdac You're right. For Alt DA, it recorded regardless of success or failure. Then I updated codes and now it records when handleReceipt is called.
Closes #321
Add the following types of metrics for AltDA failover feature