forked from ethereum-optimism/optimism
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Genesis + Allocation generation #298
Open
pahor167
wants to merge
51
commits into
celo-contracts/v1.8.0-1
Choose a base branch
from
pahor/genesisGeneration
base: celo-contracts/v1.8.0-1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's squash this so that we have one commit per feature, and then rebase this PR so that those commits land in the parent |
palango
reviewed
Jan 28, 2025
Looks good so far 💪
|
* working deploy2.s.sol from celo10 * Deployment refactor * Compilation fix * removal of deploy_orig
* working deploy2.s.sol from celo10 * Deployment refactor * Contract Deployment: Split FP initialization * Minnor format fixes --------- Co-authored-by: pahor167 <[email protected]>
* working deploy2.s.sol from celo10 * Deployment refactor * Compilation fix * removal of deploy_orig * Setup new contract for Celo-specific guardian role * Test the actual new contract * Add getter for global SuperchainConfig * Make sure global guardian can't directly pause Celo config * Rename test contracts * Return combined Superchain and Celo paused status * Allow pausing of Celo config when Superchain is paused * Ensure Celo stays paused if Superchain still paused * Add CeloSuperchainConfig to Specs test * Exclude CeloSuperchainConfig from Initializable test for now * Make test view * Use CeloSuperchainConfig interface * Check and propagate superchain paused status in one function * Setup CeloSuperchainConfig in deploy script * Point OptimismPortal to CeloSuperchainConfig * Formatting * Use CeloSuperchainConfig in contracts that used SuperchainConfig * Fix CrossDomanMessenger test * Add NatSpecs * Add unit test NatSpecs * Add reference comment to deploy script * Add comments * Emit event on config update * Initialize as paused if Superchain paused at init time * Test Celo and Superchain pauses on OptimismPortal2 * Test Celo and Superchain pauses on OptimismPortal * Test Celo and Superchain pauses on L1CrossDomainMessenger * Test Celo and Superchain pauses on L1ERC721Bridge * Use checkAndPause in L1ERC721Bridge * Add enum and event to interface * Use CeloSuperChainConfig in ChainAssertions * Remove unused script * Add CeloSuperchainConfig chain assertion --------- Co-authored-by: pahor167 <[email protected]>
m-chrzan
reviewed
Feb 7, 2025
* Check CeloSuperchainConfig in Initializable test * Ignore Celo contracts from Initializable test
…/optimism into pahor/genesisGeneration
* Use new namespace in inheriting contract * Allow unset superchainConfig
* Implement CeloSuperchainConfig standalone, without inheritance
…/optimism into pahor/genesisGeneration
* Provide an external superchain config and deploy Celo with it * Add externalSuperchainConfig in go and config template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.