Tracing celo v2.1.x #444
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| package utils | ||
|
|
||
| import ( | ||
| "time" | ||
|
|
||
| "github.com/ethereum/go-ethereum/tracing" | ||
| "github.com/urfave/cli/v2" | ||
| ) | ||
|
|
||
| var ( | ||
| // Tracing flags | ||
| TracingEnabledFlag = &cli.BoolFlag{ | ||
| Name: "tracing.enabled", | ||
| Usage: "Enable OpenTelemetry tracing", | ||
| } | ||
| TracingEndpointFlag = &cli.StringFlag{ | ||
| Name: "tracing.endpoint", | ||
| Usage: "OpenTelemetry OTLP endpoint URL", | ||
| Value: "", | ||
| } | ||
| TracingServiceNameFlag = &cli.StringFlag{ | ||
| Name: "tracing.service-name", | ||
| Usage: "Service name for tracing", | ||
| Value: "geth", | ||
| } | ||
| TracingServiceVersionFlag = &cli.StringFlag{ | ||
| Name: "tracing.service-version", | ||
| Usage: "Service version for tracing", | ||
| Value: "", | ||
| } | ||
| TracingSampleRateFlag = &cli.Float64Flag{ | ||
| Name: "tracing.sample-rate", | ||
| Usage: "Tracing sample rate (0.0 to 1.0)", | ||
| Value: 1.0, | ||
| } | ||
| TracingTimeoutFlag = &cli.DurationFlag{ | ||
| Name: "tracing.timeout", | ||
| Usage: "Tracing export timeout", | ||
| Value: 10 * time.Second, | ||
| } | ||
| TracingRPCFlag = &cli.BoolFlag{ | ||
| Name: "tracing.rpc", | ||
| Usage: "Enable RPC tracing", | ||
| Value: true, | ||
| } | ||
| TracingEngineAPIFlag = &cli.BoolFlag{ | ||
| Name: "tracing.engine-api", | ||
| Usage: "Enable Engine API tracing", | ||
| Value: true, | ||
| } | ||
| TracingTransactionFlag = &cli.BoolFlag{ | ||
| Name: "tracing.transactions", | ||
| Usage: "Enable transaction-level tracing", | ||
| Value: false, | ||
| } | ||
| ) | ||
|
|
||
| // TracingFlags contains all tracing-related flags | ||
| var TracingFlags = []cli.Flag{ | ||
| TracingEnabledFlag, | ||
| TracingEndpointFlag, | ||
| TracingServiceNameFlag, | ||
| TracingServiceVersionFlag, | ||
| TracingSampleRateFlag, | ||
| TracingTimeoutFlag, | ||
| TracingRPCFlag, | ||
| TracingEngineAPIFlag, | ||
| TracingTransactionFlag, | ||
| } | ||
|
|
||
| // SetTracing configures tracing from CLI context | ||
| func SetTracing(ctx *cli.Context) *tracing.Config { | ||
| cfg := tracing.DefaultConfig() | ||
|
|
||
| if ctx.IsSet(TracingEnabledFlag.Name) { | ||
| cfg.Enabled = ctx.Bool(TracingEnabledFlag.Name) | ||
| } | ||
|
|
||
| if ctx.IsSet(TracingEndpointFlag.Name) { | ||
| cfg.Endpoint = ctx.String(TracingEndpointFlag.Name) | ||
| if cfg.Endpoint != "" { | ||
| cfg.Enabled = true // Auto-enable if endpoint is provided | ||
| } | ||
| } | ||
|
|
||
| if ctx.IsSet(TracingServiceNameFlag.Name) { | ||
| cfg.ServiceName = ctx.String(TracingServiceNameFlag.Name) | ||
| } | ||
|
|
||
| if ctx.IsSet(TracingServiceVersionFlag.Name) { | ||
| cfg.ServiceVersion = ctx.String(TracingServiceVersionFlag.Name) | ||
| } | ||
|
|
||
| if ctx.IsSet(TracingSampleRateFlag.Name) { | ||
| cfg.SampleRate = ctx.Float64(TracingSampleRateFlag.Name) | ||
| } | ||
|
|
||
| if ctx.IsSet(TracingTimeoutFlag.Name) { | ||
| cfg.Timeout = ctx.Duration(TracingTimeoutFlag.Name) | ||
| } | ||
|
|
||
| if ctx.IsSet(TracingRPCFlag.Name) { | ||
| cfg.EnableRPCTracing = ctx.Bool(TracingRPCFlag.Name) | ||
| } | ||
|
|
||
| if ctx.IsSet(TracingEngineAPIFlag.Name) { | ||
| cfg.EnableEngineAPITracing = ctx.Bool(TracingEngineAPIFlag.Name) | ||
| } | ||
|
|
||
| if ctx.IsSet(TracingTransactionFlag.Name) { | ||
| cfg.EnableTransactionTracing = ctx.Bool(TracingTransactionFlag.Name) | ||
| } | ||
|
|
||
| return cfg | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Endpoint flag overrides explicit tracing disable
When a user explicitly sets
--tracing.enabled=falsebut also provides--tracing.endpoint, the auto-enable logic unconditionally setscfg.Enabled = trueif the endpoint is non-empty. This overrides the user's explicit intent to disable tracing, making it impossible to disable tracing when an endpoint is configured. The auto-enable should only apply when the enabled flag hasn't been explicitly set.