tracing: use correct exchange rates #352
Merged
+30
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seolaoh
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
LGTM! I updated our internal debug node with 7a83f2f and confirmed that no more CreditFees() error occurs during tracing. Now the call trace for the 2 txs are consistently showing invalid signature error which is an issue from their side. (regarding https://github.com/celo-org/celo-blockchain-planning/issues/955)
palango
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tracer for a transaction in the index N was using the state produced by the index N-1 to calculate the fee currency rates.
As part of our block context, we calculate the fee currency rates only at the beginning of the block.
With the bugged code, if some tx between the index 0 and N-1 changes the rates of the currency that the N-tx is pretending to use, the N-tx is going to generate a wrong output.