Includes baseFee in receipt of RPC response #347
Merged
+745
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kourin1996 This looks promising. Could you add a test case or extend an existing one ( |
piersy
reviewed
Mar 28, 2025
| @@ -1722,6 +1722,11 @@ func marshalReceipt(receipt *types.Receipt, blockHash common.Hash, blockNumber u | |||
| if receipt.ContractAddress != (common.Address{}) { | |||
| fields["contractAddress"] = receipt.ContractAddress | |||
| } | |||
|
|
|||
| if tx.Type() == types.CeloDynamicFeeTxV2Type { | |||
| fields["baseFee"] = (*hexutil.Big)(receipt.BaseFee) | |||
There was a problem hiding this comment.
CeloDyamicFeeV2Txs ocurring before the L2 start won't have the BaseFee field on the receipt, so what happens here when receipt.BaseFee is nil?
There was a problem hiding this comment.
it just sets null to baseFee. But added codes to omit the field if the tx type is CeloDynamicFeeTxV2 and the tx is for Celo1
Kourin1996
changed the title
|
I tested all L2 blocks on mainnet and hashes can be calculated correctly from RPC response. |
palango
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/celo-org/celo-blockchain-planning/issues/956
Closes #350
This PR adds
baseFeefield for CeloDynamicFeeTxV2 receipt because it's necessary for calculating receipt root remotely.How to check
Run
op-gethlocally with the change of this PRSwitch to
alecps/receiptRootCheckfor running test codeCopy
core/types/receipt.goandcore/types/gen_receipt_json.goin this PR into the branch (This is required for mapping JSON-RPC response properly in test code)Run
go run ./receipt_root_test --debug <Local RPC URL> 31123401and make sure it passesHow to test
I added a new script,
compat_test/hash_consistency_test.go, which calculates BlockHash, TxHash, TxRoot, ReceiptRoot, and WithdrawalsRoot across multiple blocks starting from a specified height.I ran a local
op-gethnode with the changes from the PR forAlfajores testnet and confirmed that the BlockHash, TxHash, TxRoot, ReceiptRoot, and WithdrawalsRoot of all L2 blocks were properly calculated based on RPC response locally$ go test -v ./compat_test -tags compat_test -run TestHashConsistency -timeout 1h -op-geth-url ws://localhost:9994 --start-block 31056500 --block-interval 1