-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change wording from L1 to L2 #1735
Open
atejada
wants to merge
3
commits into
celo-org:main
Choose a base branch
from
atejada:Update-L2-language-to-indicate-were-already-an-L2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Change wording from L1 to L2 #1735
atejada
wants to merge
3
commits into
celo-org:main
from
atejada:Update-L2-language-to-indicate-were-already-an-L2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Celo is an Ethereum L2, let's make that clear on the docs
✅ Deploy Preview for celo-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
History.md and from-ethereum.md needs to be checked as the changes are deeper. |
lvpeschke
requested changes
Mar 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- These changes should not be merged before the migration happens on 26th March UTC: https://x.com/Celo/status/1896617306509500661
- Without the warnings, some of the content becomes more confusing post-L2 migration: eg on
docs/developer/migrate/from-ethereum.md
, the section about the Celo native token will be wrong since it'll no longer live on the Celo-L2 chain but on Ethereum and be bridged to L2.
I would recommend doing a more in-depth rewrite of these pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Celo is an Ethereum L2, let's make that clear on the docs