Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder maps for Demo 3 added #135

Merged
merged 24 commits into from
Feb 9, 2025
Merged

Placeholder maps for Demo 3 added #135

merged 24 commits into from
Feb 9, 2025

Conversation

CeliaDawn
Copy link
Contributor

No description provided.

Copy link
Contributor

@ravepossum ravepossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just a typo or two, address and merge at your leisure!

.string "beings with out own free will.$"
.string "Fierce LITWICK: Make no mistake.\p"
.string "TRAINERS see us as tools, not as\n"
.string "being with our own free will.$"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beingS I assume?



script PokemonTower_GreatestFear {
msgbox("Beware, fair traveller, as you\nascend.\pClimbing this tower will face you\nagainst the greatest fear of any\lfanfiction author.", MSGBOX_NPC)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traveller? We British now? :^)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that's not how you spell that in American ^^;

@@ -1,6 +1,5 @@
raw `
PokemonTower_4F_MapScripts::
.byte 0
::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lingering set of colons seems like it has the potential to cause syntax error but it seems to build fine 🤔 might wanna yeet it just in case

}

script PokemonTower_NeutralAnswer {
setvar(VAR_POKEMONTOWER_ANSWER, 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the releases in these scripts necessary? My guess would be no, but if they are, we'd want to throw one in this one too right?

@CeliaDawn CeliaDawn merged commit 436a579 into beta Feb 9, 2025
1 check passed
@CeliaDawn CeliaDawn deleted the pokemon-tower branch February 9, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants