Skip to content

Drop python 3.8 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Drop python 3.8 #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6876d93
test with python3.11 and python3.13
bashir-abdelwahed Mar 15, 2025
f5624c5
consistently use python 3.8->3.13 + pypy3.10 in tests
bashir-abdelwahed Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: blacksmith-4vcpu-ubuntu-2204
strategy:
matrix:
python-version: [3.8,3.9,"3.10","3.12"]
python-version: ["3.9","3.10","3.11","3.12","3.13","pypy3.10"]
steps:
- name: Check out code from GitHub
uses: actions/checkout@v4
Expand Down
5 changes: 2 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,11 @@
Development Status :: 5 - Production/Stable
Programming Language :: Python
Programming Language :: Python :: 3
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Programming Language :: Python :: 3.12
Programming Language :: Python :: 3.13
Programming Language :: Python :: 3 :: Only
Programming Language :: Python :: Implementation :: CPython
Programming Language :: Python :: Implementation :: PyPy
Expand Down Expand Up @@ -112,7 +111,7 @@ def run_tests(self):
platforms=['any'],
classifiers=classifiers,
license='BSD',
python_requires=">=3.6",
python_requires=">=3.9",
install_requires=[],
tests_require=reqs('test.txt'),
cmdclass={'test': pytest},
Expand Down
6 changes: 3 additions & 3 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
envlist =
{pypy3,3.12,3.8,3.9,3.10}-unit
{3.9,3.10,3.11,3.12,3.13,pypy3.10}-unit
flake8
apicheck
pydocstyle
Expand All @@ -19,10 +19,10 @@ commands = py.test -xv --cov=vine --cov-report=xml --no-cov-on-fail t/unit {posa

basepython =
flake8,apicheck,linkcheck,pydocstyle: python3.10
pypy3: pypy3.10
3.8: python3.8
pypy3.10: pypy3.10
3.9: python3.9
3.10: python3.10
3.11: python3.11
3.12: python3.12

[testenv:apicheck]
Expand Down
1 change: 1 addition & 0 deletions vine/synchronization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def all_done():
Note that you cannot add new promises to a barrier after
the barrier is fulfilled.
"""

__slots__ = (
'p', 'args', 'kwargs', '_value', 'size',
'ready', 'reason', 'cancelled', 'finalized',
Expand Down