-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not pin package tzdata anymore #2274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm bit reluctant to allow this right atm. may be we can reach a consensus later. until then lets hold it.
Would really appreciate if Kombu wasn't dictating dependencies. Best practices for apps and libraries differ. Using |
^ Actually, there's an open issue #2277 about the pinning of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2274 +/- ##
=======================================
Coverage 81.55% 81.55%
=======================================
Files 77 77
Lines 9541 9541
Branches 1162 1162
=======================================
Hits 7781 7781
Misses 1568 1568
Partials 192 192 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pinning exact versions especially for libraries (rather than applications) doesn't work with Python's dependency management. It's a practice that comes from Javascript, which has an entirely different system. See https://iscinumpy.dev/post/bound-version-constraints/. |
I will come to this tomorrow |
tzdata is a timezone database that should always be upgradeable, otherwise other projects will run into dependency conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Hello everyone,
I think we can safely upgrade tzdata to newer versions and do not require a version pin, because it is just a timezone database.
This will help other projects upgrading their dependencies without running into dependency conflicts.
Thanks