-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Feature: urllib3 instead of curl" #2261
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 07c8852.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2261 +/- ##
==========================================
- Coverage 81.55% 81.07% -0.48%
==========================================
Files 77 77
Lines 9541 9627 +86
Branches 1162 1179 +17
==========================================
+ Hits 7781 7805 +24
- Misses 1568 1619 +51
- Partials 192 203 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a description and link to the issue that triggered this revert so it will be easier to track in the future. Thank you!
updated the related issue |
i think we should revert this change for now |
This change is done across celery, kombu and pytest-celery. Just merging this will make |
No problem take your time. Sorry if my comments seems pushy, all the open pr are meant to be a supporting hand only. |
Reverts #2134 to fix the performance regression related to #2258