Skip to content

PR #2198 and PR #2207 Fixed - #2219

Closed
MehrazRumman wants to merge 7 commits into
celery:mainfrom
MehrazRumman:main
Closed

MehrazRumman wants to merge 7 commits into
celery:mainfrom
MehrazRumman:main

Conversation

@MehrazRumman

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Jan 6, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.50%. Comparing base (a0175b0) to head (ea52094).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2219   +/-   ##
=======================================
  Coverage   81.50%   81.50%           
=======================================
  Files          77       77           
  Lines        9524     9524           
  Branches     1152     1152           
=======================================
  Hits         7763     7763           
  Misses       1569     1569           
  Partials      192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MehrazRumman

Copy link
Copy Markdown
Contributor Author

@auvipy can you review this PR ?

experimental: [false]
include:
- python-version: pypy3.10
toxenv: 'py-amqp'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this part have to be removed? Can you explain please?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes , I think pypy3.10 is required here for make certain workloads faster. I will undo the change .

@auvipy

auvipy commented Jan 10, 2025

Copy link
Copy Markdown
Member

You should check why integration tests are failing on pypy. Do protobuf work with pypy? If not you can skip pypy for grpc

@thedrow

thedrow commented Jan 13, 2025

Copy link
Copy Markdown

gRPC doesn't work for PyPy. See grpc/grpc#4221

@auvipy

auvipy commented Feb 5, 2025

Copy link
Copy Markdown
Member

#2240

@Nusnus
Nusnus marked this pull request as draft February 17, 2025 22:20
@auvipy

auvipy commented May 12, 2025

Copy link
Copy Markdown
Member

can you please revisit this?

@auvipy auvipy added this to the 5.7.0 milestone May 12, 2025

@auvipy auvipy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please update the dependencies? we have updated them in main branch so need sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants