fix get unique timezones

[beedub]

the previous query did not actually get distinct timezones

[cclauss]

Please run pre-commit on django_celery_beat/schedulers.py

[beedub]

@cclauss updated

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.99%. Comparing base (70d381b) to head (2c23b14).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
django_celery_beat/schedulers.py	75.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   88.19%   87.99%   -0.20%     
==========================================
  Files          32       32              
  Lines        1008     1008              
  Branches      105      105              
==========================================
- Hits          889      887       -2     
- Misses        101      102       +1     
- Partials       18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[auvipy]

@alirafiei75 please take a look

[auvipy]

can we get additional tests for this?

[beedub]

@auvipy can you suggest what additional tests you want here?

[auvipy]

there are failing tests now, can you fix them?

[auvipy]

The rebase didn’t work. Please make it errorless again

[auvipy]

Why are we removing the tests?

[beedub]

it's the same test as the one below test_timezone_offset_with_zoneinfo_object_param, except that it tests with string timezone names, which as discussed, is not possible given that timezone always returns ZoneInfo

[auvipy]

can we add more tests which also improve the test coverage? and there is no regression introduced?

[beedub]

if you're referring to the codecov note, then i would guess it's b/c the tests only run with sqlite. can you confirm?

if so, i don't have have the bandwidth to update the test suite to also run a build with non-sqlite (eg. postgres). i can remove the sqlite/non-sqlite conditional in that code even though it'll be less performant, but i think it'll increase the codecov by virtue of not having a non-tested branch

re: regressions, there are existing tests from the original PR that introduced this change that should cover regressions. this change is a performance improvement

[Copilot]

Pull Request Overview

This PR addresses the issue where distinct timezones were not actually being retrieved, and updates related tests to use timezone-aware datetime.

• Refactors scheduler to introduce _get_unique_timezones and adjust _get_crontab_exclude_query and _get_timezone_offset to work with ZoneInfo
• Adds a new test_get_unique_timezones to verify unique timezone retrieval and converts test timestamps to UTC-aware datetimes
• Updates imports and annotations to support the new implementations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
t/unit/test_schedulers.py	Replaced datetime.utcnow() with datetime.now(dt_timezone.utc) and added test_get_unique_timezones
django_celery_beat/schedulers.py	Added _get_unique_timezones, updated _get_crontab_exclude_query and _get_timezone_offset, and imported connection

Comments suppressed due to low confidence (2)

django_celery_beat/schedulers.py:390

• The docstring still refers to timezone_name even though the parameter is now timezone (a ZoneInfo). Update the docstring to match the new parameter name and type for clarity.

    def _get_timezone_offset(self, timezone: ZoneInfo) -> int:

t/unit/test_schedulers.py:1230

• [nitpick] The test docstring says it returns a "list" of timezones but actually asserts against a set. Consider updating the docstring to say "set" for consistency.

        Test that get unique timezones returns a list of unique timezones

[Copilot]

The method currently returns raw timezone name strings but declares a return type of set[ZoneInfo] and tests expect ZoneInfo instances. Consider mapping each string to ZoneInfo, e.g. set(ZoneInfo(tz) for tz in ...), to ensure the returned values match the signature and test expectations.

[Copilot]

This lookup uses a ZoneInfo object for the timezone field, but the database stores timezones as strings. Convert to str(timezone) or timezone.key so the ORM lookup matches the stored values.

Suggested change

	timezone=timezone,
	timezone=str(timezone),