fix: revert encrypt workaround after Poulpy prepare fix#25
Conversation
- Bump poulpy to rev 067fd785; encrypt via FheUint::encrypt_sk + glwe enc infos - Drop prepared cache on Ciphertext; eval_binary prepares operands with fhe_uint_prepare_tmp_bytes - Size scratch from Poulpy *_tmp_bytes for encrypt, decrypt, keygen, and each homomorphic op - encrypt now takes (value, sk) only; update README, example, and tests - Mark milestone issue #24 done in README
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
📝 WalkthroughWalkthroughCargo.toml dependencies updated to specific poulpy commit revisions. The codebase removes the cached "prepared" ciphertext mechanism from Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant Context
participant Ciphertext as Ciphertext<br/>(packed only)
participant Backend as Backend<br/>(eval_binary)
rect rgba(100, 200, 100, 0.5)
Note over User,Backend: NEW FLOW: On-demand preparation
User->>Context: encrypt(value, &sk)
Context->>Ciphertext: new (inner only)
Ciphertext-->>User: Ciphertext<T>
User->>Context: add(&ct_a, &ct_b, &ek)
Context->>Context: rebuild FheUintPrepared from ct_a.inner
Context->>Context: rebuild FheUintPrepared from ct_b.inner
Context->>Backend: eval(prepared_a, prepared_b)
Backend-->>Context: result (packed)
Context->>Ciphertext: new (inner only)
Ciphertext-->>User: Ciphertext<T>
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary by CodeRabbit
API Changes
encrypt()method signature—evaluation key parameter no longer required, streamlining encryption calls.Improvements
Documentation