Skip to content

Conversation

@Tobbe
Copy link
Member

@Tobbe Tobbe commented Oct 29, 2025

Should be no user facing changes. But I'm jumping two major versions here, and it's related to how we build. So worth keeping an extra eye out.

@Tobbe Tobbe added this to the chore milestone Oct 29, 2025
@netlify
Copy link

netlify bot commented Oct 29, 2025

Deploy Preview for cedarjs canceled.

Name Link
🔨 Latest commit d3df813
🔍 Latest deploy log https://app.netlify.com/projects/cedarjs/deploys/69027ba2ffe72a0008fd3a23

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Upgraded Nx build system from v20.8.2 to v22.0.2, jumping two major versions.

Key Changes:

  • Single dependency version bump in package.json
  • All platform-specific Nx binaries updated (Darwin, Linux, Windows variants)
  • Transitive dependency updates: @jest/diff-sequences (30.0.1), @jest/get-type (30.1.0), @jest/schemas (30.0.5), jest-diff (30.2.0)
  • Added @sinclair/typebox (0.34.41) as new transitive dependency
  • Updated axios from 1.11.0 to 1.13.1
  • Existing nx.json configuration appears compatible with v22 (uses standard targetDefaults, namedInputs, and caching)

Testing Considerations:

  • Verify build pipeline works correctly with new Nx version
  • Check that caching behavior is still optimal
  • Ensure all CI workflows execute successfully
  • Test that nx run-many commands work as expected across all targets (build, test, build:pack)

Confidence Score: 4/5

  • This PR is reasonably safe to merge but requires thorough CI testing due to the two major version jump
  • The upgrade is clean (only dependency changes, no code modifications) and the existing nx.json configuration uses standard, stable features. However, jumping from v20 to v22 skips v21 entirely, which could introduce unexpected breaking changes in build behavior, caching, or task execution. The score of 4 reflects that while the change is structurally sound, the magnitude of the version jump warrants careful CI validation before merging.
  • No files require special attention - this is a straightforward dependency upgrade

Important Files Changed

File Analysis

Filename Score Overview
package.json 5/5 Nx version upgraded from 20.8.2 to 22.0.2 - a two major version jump that affects build tooling
yarn.lock 5/5 Updated lockfile with Nx v22.0.2 dependencies, including platform-specific binaries and updated Jest-related transitive dependencies

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager (Yarn)
    participant Nx as Nx Build System
    participant CI as CI/CD Pipeline
    
    Dev->>PM: Update package.json (nx: 20.8.2 → 22.0.2)
    Dev->>PM: yarn install
    PM->>PM: Resolve dependencies
    PM->>PM: Download Nx v22.0.2 + platform binaries
    PM->>PM: Update transitive deps (@jest/*, @sinclair/typebox)
    PM->>PM: Write yarn.lock
    
    Note over PM: 238 lines changed in yarn.lock:<br/>+223 additions, -15 deletions
    
    Dev->>Nx: Verify nx.json compatibility
    Nx->>Nx: Validate configuration schema
    Nx->>Nx: Check targetDefaults (build, test, build:pack)
    Nx->>Nx: Verify namedInputs and cache settings
    
    Dev->>CI: Push changes
    CI->>PM: yarn install
    CI->>Nx: nx run-many -t build
    Nx->>Nx: Execute build tasks with caching
    CI->>Nx: nx run-many -t test
    Nx->>Nx: Execute test tasks with caching
    
    Note over Dev,CI: Major version jump (v20 → v22)<br/>requires careful testing of build<br/>and caching behavior
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@Tobbe Tobbe merged commit f4637f6 into main Oct 30, 2025
39 of 40 checks passed
@Tobbe Tobbe deleted the tobbe-nx-22 branch October 30, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants