Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/set-up-job/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ runs:
- name: ⬢ Set up Node.js
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 24

# We have to enable Corepack again for Windows. 🤷
# In general, we're waiting on [this issue](https://github.com/actions/setup-node/issues/531)
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,14 @@ jobs:
matrix:
os: [ubuntu-latest, windows-latest]

name: 🏗 Build, lint, test / ${{ matrix.os }} / node 20 latest
name: 🏗 Build, lint, test / ${{ matrix.os }} / node 24 latest
uses: ./.github/workflows/build-lint-test.yml
with:
os: ${{ matrix.os }}

tutorial-e2e:
needs: check
name: 🌲 Tutorial E2E / node 20 latest
name: 🌲 Tutorial E2E / node 24 latest
uses: ./.github/workflows/tutorial-e2e.yml

smoke-tests:
Expand All @@ -100,7 +100,7 @@ jobs:
matrix:
os: [ubuntu-latest, windows-latest]

name: 🔄 Smoke tests / ${{ matrix.os }} / node 20 latest
name: 🔄 Smoke tests / ${{ matrix.os }} / node 24 latest
uses: ./.github/workflows/smoke-tests-test.yml
with:
os: ${{ matrix.os }}
Expand All @@ -112,7 +112,7 @@ jobs:
matrix:
os: [ubuntu-latest, windows-latest]

name: 🔄 Smoke tests React 18 / ${{ matrix.os }} / node 20 latest
name: 🔄 Smoke tests React 18 / ${{ matrix.os }} / node 24 latest
uses: ./.github/workflows/smoke-tests-react-18-test.yml
with:
os: ${{ matrix.os }}
Expand All @@ -124,7 +124,7 @@ jobs:
matrix:
os: [ubuntu-latest, windows-latest]

name: 🔄 Smoke tests ESM / ${{ matrix.os }} / node 20 latest
name: 🔄 Smoke tests ESM / ${{ matrix.os }} / node 24 latest
uses: ./.github/workflows/smoke-tests-test-esm.yml
with:
os: ${{ matrix.os }}
Expand All @@ -136,7 +136,7 @@ jobs:
matrix:
os: [ubuntu-latest, windows-latest]

name: 🔄 CLI smoke tests / ${{ matrix.os }} / node 20 latest
name: 🔄 CLI smoke tests / ${{ matrix.os }} / node 24 latest
uses: ./.github/workflows/cli-smoke-tests.yml
with:
os: ${{ matrix.os }}
Expand All @@ -148,7 +148,7 @@ jobs:
matrix:
os: [ubuntu-latest, windows-latest]

name: 🔭 Telemetry check / ${{ matrix.os }} / node 20 latest
name: 🔭 Telemetry check / ${{ matrix.os }} / node 24 latest
uses: ./.github/workflows/telemetry-check.yml
with:
os: ${{ matrix.os }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/create-cedar-app-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
- name: ⬢ Set up Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: 18
node-version: 20

- name: Prompt tests
run: ./tests/e2e_prompts_node_less.sh
Expand All @@ -66,7 +66,7 @@ jobs:
- name: ⬢ Set up Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: 21
node-version: 25

- name: Prompt tests
run: ./tests/e2e_prompts_node_greater.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-release-candidate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: ⬢ Set up Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: 20
node-version: 24

- name: 🏷 Check git tags
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/require-milestone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: ⬢ Set up Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: 20
node-version: 24

- name: ✅ Check milestone
uses: ./.github/actions/require-milestone
2 changes: 1 addition & 1 deletion .github/workflows/require-release-label.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: ⬢ Set up Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: 20
node-version: 24

- name: ✅ Check release label requirement
uses: ./.github/actions/require-release-label-or-cc-message
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ what you use so I know what to keep and what to remove!
- [ ] Future major version: Make it possible to switch existing Cedar apps to
ESM
- [ ] Enable strict mode for new Cedar TypeScript apps.
- [ ] Upgrade to Node 24
- [x] Upgrade to Node 24
- [x] Setup dependabot/renovate to automatically merge PRs that pass all checks
- [x] Move to Vitest for Cedar ESM apps

Expand Down
2 changes: 1 addition & 1 deletion __fixtures__/esm-fragment-test-project/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"root": true
},
"engines": {
"node": "=20.x"
"node": "=24.x"
},
"prisma": {
"seed": "yarn rw exec seed"
Expand Down
4 changes: 2 additions & 2 deletions __fixtures__/esm-test-project/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"root": true
},
"engines": {
"node": "=20.x"
"node": "=24.x"
},
"prisma": {
"seed": "yarn rw exec seed"
Expand All @@ -30,4 +30,4 @@
"react-is": "19.0.0-rc-f2df5694-20240916",
"vite": "5.4.16"
}
}
}
2 changes: 1 addition & 1 deletion __fixtures__/fragment-test-project/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"root": true
},
"engines": {
"node": "=20.x"
"node": "=24.x"
},
"prisma": {
"seed": "yarn rw exec seed"
Expand Down
2 changes: 1 addition & 1 deletion __fixtures__/rsc-caching/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"root": true
},
"engines": {
"node": "=20.x"
"node": "=24.x"
},
"prisma": {
"seed": "yarn rw exec seed"
Expand Down
2 changes: 1 addition & 1 deletion __fixtures__/test-project-rsa/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"root": true
},
"engines": {
"node": "=20.x"
"node": "=24.x"
},
"prisma": {
"seed": "yarn rw exec seed"
Expand Down
2 changes: 1 addition & 1 deletion __fixtures__/test-project-rsc-kitchen-sink/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"root": true
},
"engines": {
"node": "=20.x"
"node": "=24.x"
},
"prisma": {
"seed": "yarn rw exec seed"
Expand Down
4 changes: 2 additions & 2 deletions __fixtures__/test-project/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"root": true
},
"engines": {
"node": "=20.x"
"node": "=24.x"
},
"prisma": {
"seed": "yarn rw exec seed"
Expand All @@ -27,4 +27,4 @@
"@storybook/react-dom-shim@npm:7.6.20": "https://verdaccio.tobbe.dev/@storybook/react-dom-shim/-/react-dom-shim-8.0.8.tgz",
"react-is": "19.0.0-rc-f2df5694-20240916"
}
}
}
1 change: 0 additions & 1 deletion docs/.node-version

This file was deleted.

4 changes: 2 additions & 2 deletions docs/docs/how-to/test-in-github-actions.md
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ jobs:

strategy:
matrix:
node-version: [20.x]
node-version: [24.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

services:
Expand Down Expand Up @@ -302,7 +302,7 @@ jobs:

strategy:
matrix:
node-version: [20.x]
node-version: [24.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

services:
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/quick-start.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ description: CedarJS quick start

:::info Prerequisites

- CedarJS requires [Node.js](https://nodejs.org/en/) (=20.19.x) and
- CedarJS requires [Node.js](https://nodejs.org/en/) (=24.x) and
[Yarn](https://yarnpkg.com/) (>=1.22.21)
- Are you on Windows? For best results, follow our [Windows development
setup](how-to/windows-development-setup.md) guide
Expand Down
4 changes: 2 additions & 2 deletions packages/create-cedar-app/src/create-cedar-app.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@ async function executeCompatibilityCheck(templateDir) {
}

/**
*
* This type has to be updated if the engines field in the create redwood app template package.json is updated.
* This type has to be updated if the engines field in the create cedar app
* template package.json is updated.
* @returns [boolean, Record<'node' | 'yarn', any>]
*/
function checkNodeVersion(templateDir) {
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cedar-app/templates/esm-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"root": true
},
"engines": {
"node": "=20.x"
"node": "=24.x"
},
"prisma": {
"seed": "yarn rw exec seed"
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cedar-app/templates/esm-ts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"root": true
},
"engines": {
"node": "=20.x"
"node": "=24.x"
},
"prisma": {
"seed": "yarn rw exec seed"
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cedar-app/templates/js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"root": true
},
"engines": {
"node": "=20.x"
"node": "=24.x"
},
"prisma": {
"seed": "yarn rw exec seed"
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cedar-app/templates/ts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"root": true
},
"engines": {
"node": "=20.x"
"node": "=24.x"
},
"prisma": {
"seed": "yarn rw exec seed"
Expand Down
4 changes: 2 additions & 2 deletions packages/create-cedar-rsc-app/src/latest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ import process from 'node:process'

import type { Config } from './config.js'
import { ExitCodeError } from './error.js'
import { getCrxrscaVersion } from './version.js'
import { getCcrscaVersion } from './version.js'

export function shouldRelaunch(config: Config) {
if (config.verbose) {
console.log('shouldRelaunch process.argv', process.argv)
console.log('shouldRelaunch crwrsca version', getCrxrscaVersion())
console.log('shouldRelaunch crwrsca version', getCcrscaVersion())
}

if (process.argv.includes('--no-check-latest')) {
Expand Down
4 changes: 2 additions & 2 deletions packages/create-cedar-rsc-app/src/messages.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import ansis from 'ansis'

import type { Config } from './config.js'
import { getCrxrscaVersion } from './version.js'
import { getCcrscaVersion } from './version.js'

export function printWelcome() {
console.log()
Expand All @@ -10,7 +10,7 @@ export function printWelcome() {
.hex('#bf4722')
.bold(
'🌲 Welcome to the Cedar RSC quick-start installer ' +
`v${getCrxrscaVersion()} 🌲`,
`v${getCcrscaVersion()} 🌲`,
),
)
console.log()
Expand Down
9 changes: 3 additions & 6 deletions packages/create-cedar-rsc-app/src/prerequisites.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,9 @@ export function checkNodeVersion(config: Config) {
console.log('Node version:', version)
}

// https://github.com/redwoodjs/redwood/issues/10492#issuecomment-2076063552
// The comment above and the one after explains why we check specifically
// for >= 20.10.0
if (!semver.satisfies(version, '>=20.10')) {
console.error('❌Your Node.js version must be >=20.10.0')
console.error('Please install or switch to a newer version of Node')
if (!semver.satisfies(version, '=24')) {
console.error('❌You must be using Node.js version 24')
console.error('Please install or switch to the correct version of Node')
console.error(
'We recommend using a Node version manager like `fnm`, `nvm` or `n`',
)
Expand Down
4 changes: 2 additions & 2 deletions packages/create-cedar-rsc-app/src/version.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import fs from 'node:fs'

export function getCrxrscaVersion() {
export function getCcrscaVersion() {
const packageJson = JSON.parse(
fs.readFileSync(new URL('../package.json', import.meta.url), 'utf-8'),
)
Expand All @@ -10,5 +10,5 @@ export function getCrxrscaVersion() {
}

export function printVersion() {
console.log(`create-cedar-rsc-app v${getCrxrscaVersion()}`)
console.log(`create-cedar-rsc-app v${getCcrscaVersion()}`)
}
2 changes: 1 addition & 1 deletion packages/storybook/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"storybook": "7.6.20"
},
"engines": {
"node": "=20.x"
"node": "=24.x"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion tasks/server-tests/fixtures/redwood-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"packageManager": "[email protected]",
"engines": {
"node": "=20.x"
"node": "=24.x"
},
"prisma": {
"seed": "yarn rw exec seed"
Expand Down
Loading