-
Notifications
You must be signed in to change notification settings - Fork 11
chore(ona): Update docs and config files to reference CedarJS #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cedarjs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Summary
This PR updates Ona-related configuration files and documentation to rebrand from RedwoodJS to CedarJS. The changes include updating workspace names, folder paths, service descriptions, and documentation links to reference CedarJS resources.
Major changes:
- Dev Container configuration updated from RedwoodGraphQL to CedarJS workspace naming
- Ona automations updated with CedarJS branding in service names and descriptions
- Documentation updated with new Ona badge URLs and cedarjs/starter repository links
- Test app directory renamed from
rw-test-apptocdr-test-appin most places
Issues found:
.ona/automations.yamlline 70: Still referencesrw-test-appinstead ofcdr-test-app, causing the sync task to fail.ona/automations.yamlline 34: Referencesredwood.tomlbut CedarJS usescedar.toml- Several legacy RedwoodJS environment variable names and commands (
RWFW_PATH,REDWOOD_DISABLE_TELEMETRY,rwfw) remain - verify if intentional for backward compatibility
Confidence Score: 2/5
- This PR contains critical bugs that will cause the Ona automation setup to fail
- Score reflects two critical logic errors in
.ona/automations.yamlthat will break the sync-framework-changes task (wrong directory path) and setup-environment task (wrong config file name). These bugs will cause runtime failures when users try to use the Ona environment. .ona/automations.yamlrequires immediate fixes on lines 34 and 70 before merging
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .devcontainer/devcontainer.json | 5/5 | Successfully updated all references from RedwoodGraphQL to CedarJS, including workspace folder path |
| .ona/automations.yaml | 2/5 | Mostly updated but contains critical bugs: line 70 uses wrong directory path, line 34 references wrong config file name, legacy env vars and command names remain |
| docs/docs/how-to/using-ona.md | 5/5 | Properly updated all RedwoodJS references to CedarJS and updated Ona button links |
| docs/docs/quick-start.md | 5/5 | Successfully updated Ona badge URL and repository reference to cedarjs/starter |
Sequence Diagram
sequenceDiagram
participant User
participant Ona
participant DevContainer
participant Automations
participant CedarApp
User->>Ona: Click "Run in Ona" button
Ona->>DevContainer: Initialize devcontainer.json
DevContainer->>DevContainer: Setup Node.js 20 environment
DevContainer->>DevContainer: Install corepack & enable
DevContainer->>Automations: Trigger postDevcontainerStart
par Setup Environment
Automations->>Automations: Export RWFW_PATH & env vars
Automations->>Automations: Clean cache & symlinks
Automations->>Automations: Install framework dependencies
Automations->>CedarApp: Build test project (cdr-test-app)
CedarApp->>CedarApp: Modify cedar.toml config
Automations->>Ona: Open ports 8910 & 8911 (HTTPS)
Automations->>Automations: Create completion flag
and Start Dev Server
Automations->>Automations: Wait for setup completion
Automations->>Ona: Ensure ports are open
Automations->>CedarApp: Start dev-server service
end
CedarApp-->>User: Development environment ready
User->>CedarApp: Access Web (8910) & API (8911)
4 files reviewed, 4 comments
Update Ona-related config files and docs to say Cedar instead of RW, point towards Cedar resources, and use newer Ona links instead of gitpod links.
This continues work started in #475 (and redwoodjs/graphql#12093)