-
Notifications
You must be signed in to change notification settings - Fork 11
feat: migrate from Gitpod Classic to Ona #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "name": "RedwoodGraphQL", | ||
| "image": "mcr.microsoft.com/devcontainers/javascript-node:1-20-bullseye", | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/github-cli:1": {} | ||
| }, | ||
| "workspaceFolder": "/workspaces/RedwoodGraphQL", | ||
Tobbe marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "forwardPorts": [8910, 8911], | ||
| "portsAttributes": { | ||
| "8910": { | ||
| "label": "RedwoodJS Web", | ||
| "onAutoForward": "notify" | ||
Tobbe marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| "8911": { | ||
| "label": "RedwoodJS API", | ||
Tobbe marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "onAutoForward": "ignore" | ||
| } | ||
| }, | ||
| "postCreateCommand": "npm i -g corepack --force && corepack enable" | ||
| } | ||
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,130 @@ | ||||||||||||||||||||||
| services: | ||||||||||||||||||||||
| dev-server: | ||||||||||||||||||||||
| name: RedwoodJS Development Server | ||||||||||||||||||||||
| description: Runs the RedwoodJS development server for both web and api sides | ||||||||||||||||||||||
Tobbe marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||
| commands: | ||||||||||||||||||||||
| start: | | ||||||||||||||||||||||
| # Ensure corepack is enabled in service environment | ||||||||||||||||||||||
| corepack enable | ||||||||||||||||||||||
| cd /workspaces/rw-test-app | ||||||||||||||||||||||
| NODE_ENV=development corepack yarn rw dev | ||||||||||||||||||||||
|
Comment on lines
+9
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Working directory and command reference incorrect project directory. Cedar uses
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .ona/automations.yaml
Line: 9:10
Comment:
**logic:** Working directory and command reference incorrect project directory. Cedar uses `cdr` instead of `rw` command.
```suggestion
cd /workspaces/cedar-test-app
NODE_ENV=development corepack yarn cdr dev
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||
| tasks: | ||||||||||||||||||||||
| setup-environment: | ||||||||||||||||||||||
| name: Setup RedwoodJS Environment | ||||||||||||||||||||||
| description: Setup RedwoodJS development environment (runs automatically after devcontainer starts) | ||||||||||||||||||||||
|
Comment on lines
+14
to
+15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Task references "RedwoodJS" instead of "Cedar"
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .ona/automations.yaml
Line: 14:15
Comment:
**logic:** Task references "RedwoodJS" instead of "Cedar"
```suggestion
name: Setup Cedar Environment
description: Setup Cedar development environment (runs automatically after devcontainer starts)
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||
| triggeredBy: | ||||||||||||||||||||||
| - postDevcontainerStart | ||||||||||||||||||||||
| command: | | ||||||||||||||||||||||
| export RWFW_PATH="/workspaces/RedwoodGraphQL" | ||||||||||||||||||||||
| export REDWOOD_DISABLE_TELEMETRY=1 | ||||||||||||||||||||||
| echo "Setting up RedwoodJS development environment..." | ||||||||||||||||||||||
| mkdir -p /workspaces/rw-test-app | ||||||||||||||||||||||
| cd /workspaces/RedwoodGraphQL | ||||||||||||||||||||||
|
Comment on lines
+19
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Environment variables and paths reference "RedwoodGraphQL" and "RedwoodJS" instead of "cedar"
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .ona/automations.yaml
Line: 19:23
Comment:
**logic:** Environment variables and paths reference "RedwoodGraphQL" and "RedwoodJS" instead of "cedar"
```suggestion
export RWFW_PATH="/workspaces/cedar"
export REDWOOD_DISABLE_TELEMETRY=1
echo "Setting up Cedar development environment..."
mkdir -p /workspaces/cedar-test-app
cd /workspaces/cedar
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||
| echo "Cleaning up existing symlinks and cache..." | ||||||||||||||||||||||
| rm -rf node_modules/@redwoodjs | ||||||||||||||||||||||
| rm -rf node_modules/.cache | ||||||||||||||||||||||
| rm -f yarn.lock | ||||||||||||||||||||||
|
Comment on lines
+25
to
+27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Cleanup references
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .ona/automations.yaml
Line: 25:27
Comment:
**logic:** Cleanup references `@redwoodjs` packages. Should reference `@cedarjs`.
```suggestion
echo "Cleaning up existing symlinks and cache..."
rm -rf node_modules/@cedarjs
rm -rf node_modules/.cache
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||
| corepack yarn cache clean --all 2>/dev/null || true | ||||||||||||||||||||||
| echo "Installing framework dependencies..." | ||||||||||||||||||||||
| corepack yarn install | ||||||||||||||||||||||
| echo "Building test project..." | ||||||||||||||||||||||
| corepack yarn run build:test-project ../rw-test-app --typescript --link --verbose | ||||||||||||||||||||||
| cd /workspaces/rw-test-app | ||||||||||||||||||||||
| sed -i "s/\(open *= *\).*/\1false/" redwood.toml | ||||||||||||||||||||||
|
Comment on lines
+32
to
+34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Build command references wrong test app directory and
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .ona/automations.yaml
Line: 32:34
Comment:
**logic:** Build command references wrong test app directory and `redwood.toml`. Cedar uses `cedar.toml`.
```suggestion
echo "Building test project..."
corepack yarn run build:test-project ../cedar-test-app --typescript --link --verbose
cd /workspaces/cedar-test-app
sed -i "s/\(open *= *\).*/\1false/" cedar.toml
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||
| echo -e "\n\n\033[94m ======================================================\n\033[33m ⌛ RedwoodJS development environment is ready!\n Test app \"rw-test-app\" has been generated & linked with framework code.\n\n If you make changes to the framework:\n 1. \033[33mEnsure env vars are set \033[92mexport RWFW_PATH=\"/workspaces/RedwoodGraphQL\"\033[33m\n 2. \033[33mRun \033[92mcorepack yarn rwfw project:sync\033[33m to sync changes\n 3. \033[33mOr use the \033[92mSync Framework Changes\033[33m task from Ona dashboard\n\033[94m ======================================================\n\n" | ||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Echo message references "RedwoodJS" and incorrect paths. Should reference "Cedar" and correct workspace paths.
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .ona/automations.yaml
Line: 35:35
Comment:
**logic:** Echo message references "RedwoodJS" and incorrect paths. Should reference "Cedar" and correct workspace paths.
```suggestion
echo -e "\n\n\033[94m ======================================================\n\033[33m ⌛ Cedar development environment is ready!\n Test app \"cedar-test-app\" has been generated & linked with framework code.\n\n If you make changes to the framework:\n 1. \033[33mEnsure env vars are set \033[92mexport RWFW_PATH=\"/workspaces/cedar\"\033[33m\n 2. \033[33mRun \033[92mcorepack yarn rwfw project:sync\033[33m to sync changes\n 3. \033[33mOr use the \033[92mSync Framework Changes\033[33m task from Ona dashboard\n\033[94m ======================================================\n\n"
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||
| # Open ports for RedwoodJS development servers | ||||||||||||||||||||||
| echo "Opening ports for development servers..." | ||||||||||||||||||||||
| gitpod environment port open 8910 --name "RedwoodJS Web Server" --protocol https | ||||||||||||||||||||||
| gitpod environment port open 8911 --name "RedwoodJS API Server" --protocol https | ||||||||||||||||||||||
| echo "✅ Ports 8910 (Web) and 8911 (API) are now open with HTTPS" | ||||||||||||||||||||||
|
Comment on lines
+38
to
+40
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Port names reference "RedwoodJS" instead of "Cedar"
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .ona/automations.yaml
Line: 38:40
Comment:
**logic:** Port names reference "RedwoodJS" instead of "Cedar"
```suggestion
echo "Opening ports for development servers..."
gitpod environment port open 8910 --name "Cedar Web Server" --protocol https
gitpod environment port open 8911 --name "Cedar API Server" --protocol https
echo "✅ Ports 8910 (Web) and 8911 (API) are now open with HTTPS"
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||
| # Signal completion | ||||||||||||||||||||||
| touch /tmp/redwood-setup-complete | ||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: Completion marker references "redwood". Should use "cedar" for consistency.
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .ona/automations.yaml
Line: 42:42
Comment:
**style:** Completion marker references "redwood". Should use "cedar" for consistency.
```suggestion
touch /tmp/cedar-setup-complete
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||
| echo "✅ Setup task completed successfully" | ||||||||||||||||||||||
| start-dev-after-setup: | ||||||||||||||||||||||
| name: Start Development Server After Setup | ||||||||||||||||||||||
| description: Automatically start the development server after setup completes | ||||||||||||||||||||||
| triggeredBy: | ||||||||||||||||||||||
| - postDevcontainerStart | ||||||||||||||||||||||
| command: | | ||||||||||||||||||||||
| # Wait for setup to complete | ||||||||||||||||||||||
| echo "Waiting for setup to complete..." | ||||||||||||||||||||||
| while [ ! -f /tmp/redwood-setup-complete ]; do | ||||||||||||||||||||||
| sleep 2 | ||||||||||||||||||||||
| done | ||||||||||||||||||||||
|
Comment on lines
+53
to
+55
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Waiting logic references wrong completion file. Should match the file created in setup.
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .ona/automations.yaml
Line: 53:55
Comment:
**logic:** Waiting logic references wrong completion file. Should match the file created in setup.
```suggestion
echo "Waiting for setup to complete..."
while [ ! -f /tmp/cedar-setup-complete ]; do
sleep 2
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||
| echo "Setup completed, starting development server..." | ||||||||||||||||||||||
| # Ensure ports are open before starting service | ||||||||||||||||||||||
| gitpod environment port open 8910 --name "RedwoodJS Web Server" --protocol https 2>/dev/null || true | ||||||||||||||||||||||
| gitpod environment port open 8911 --name "RedwoodJS API Server" --protocol https 2>/dev/null || true | ||||||||||||||||||||||
|
Comment on lines
+58
to
+59
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Port open commands reference "RedwoodJS" instead of "Cedar"
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .ona/automations.yaml
Line: 58:59
Comment:
**logic:** Port open commands reference "RedwoodJS" instead of "Cedar"
```suggestion
gitpod environment port open 8910 --name "Cedar Web Server" --protocol https 2>/dev/null || true
gitpod environment port open 8911 --name "Cedar API Server" --protocol https 2>/dev/null || true
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||
| gitpod automations service start dev-server | ||||||||||||||||||||||
| echo "✅ Development server started" | ||||||||||||||||||||||
| sync-framework-changes: | ||||||||||||||||||||||
| name: Sync Framework Changes | ||||||||||||||||||||||
| description: Manually sync framework changes to test project | ||||||||||||||||||||||
| triggeredBy: | ||||||||||||||||||||||
| - manual | ||||||||||||||||||||||
| command: | | ||||||||||||||||||||||
| export RWFW_PATH="/workspaces/RedwoodGraphQL" | ||||||||||||||||||||||
| cd /workspaces/rw-test-app | ||||||||||||||||||||||
| corepack yarn rwfw project:sync | ||||||||||||||||||||||
|
Comment on lines
+69
to
+71
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Sync task references wrong workspace path and test app directory
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .ona/automations.yaml
Line: 69:71
Comment:
**logic:** Sync task references wrong workspace path and test app directory
```suggestion
export RWFW_PATH="/workspaces/cedar"
cd /workspaces/cedar-test-app
corepack yarn rwfw project:sync
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||
| echo "Framework changes synced to test project" | ||||||||||||||||||||||
| start-dev-server: | ||||||||||||||||||||||
| name: Start Development Server | ||||||||||||||||||||||
| description: Start the RedwoodJS development server | ||||||||||||||||||||||
Tobbe marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||
| triggeredBy: | ||||||||||||||||||||||
| - manual | ||||||||||||||||||||||
| command: | | ||||||||||||||||||||||
| gitpod automations service start dev-server | ||||||||||||||||||||||
| stop-dev-server: | ||||||||||||||||||||||
| name: Stop Development Server | ||||||||||||||||||||||
| description: Stop the RedwoodJS development server | ||||||||||||||||||||||
Tobbe marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||
| triggeredBy: | ||||||||||||||||||||||
| - manual | ||||||||||||||||||||||
| command: | | ||||||||||||||||||||||
| gitpod automations service stop dev-server | ||||||||||||||||||||||
| restart-dev-server: | ||||||||||||||||||||||
| name: Restart Development Server | ||||||||||||||||||||||
| description: Restart the RedwoodJS development server | ||||||||||||||||||||||
Tobbe marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||
| triggeredBy: | ||||||||||||||||||||||
| - manual | ||||||||||||||||||||||
| command: | | ||||||||||||||||||||||
| gitpod automations service stop dev-server | ||||||||||||||||||||||
| sleep 2 | ||||||||||||||||||||||
| gitpod automations service start dev-server | ||||||||||||||||||||||
| open-ports: | ||||||||||||||||||||||
| name: Open Development Ports | ||||||||||||||||||||||
| description: Open ports 8910 (Web) and 8911 (API) for external access with HTTPS | ||||||||||||||||||||||
| triggeredBy: | ||||||||||||||||||||||
| - manual | ||||||||||||||||||||||
| command: | | ||||||||||||||||||||||
| echo "Opening RedwoodJS development ports with HTTPS..." | ||||||||||||||||||||||
| gitpod environment port open 8910 --name "RedwoodJS Web Server" --protocol https | ||||||||||||||||||||||
| gitpod environment port open 8911 --name "RedwoodJS API Server" --protocol https | ||||||||||||||||||||||
| echo "✅ Ports opened successfully with HTTPS protocol" | ||||||||||||||||||||||
Tobbe marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||
| gitpod environment port list | ||||||||||||||||||||||
| close-ports: | ||||||||||||||||||||||
| name: Close Development Ports | ||||||||||||||||||||||
| description: Close ports 8910 (Web) and 8911 (API) | ||||||||||||||||||||||
| triggeredBy: | ||||||||||||||||||||||
| - manual | ||||||||||||||||||||||
| command: | | ||||||||||||||||||||||
| echo "Closing RedwoodJS development ports..." | ||||||||||||||||||||||
Tobbe marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||
| gitpod environment port close 8910 | ||||||||||||||||||||||
| gitpod environment port close 8911 | ||||||||||||||||||||||
| echo "✅ Ports closed successfully" | ||||||||||||||||||||||
| list-ports: | ||||||||||||||||||||||
| name: List Port Status | ||||||||||||||||||||||
| description: Show current status of all ports | ||||||||||||||||||||||
| triggeredBy: | ||||||||||||||||||||||
| - manual | ||||||||||||||||||||||
| command: | | ||||||||||||||||||||||
| echo "Current port status:" | ||||||||||||||||||||||
| gitpod environment port list | ||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.