Skip to content

Conversation

@AllanJard
Copy link
Contributor

Also adds the styling support libraries for this package.

I'm very grateful that you already host the datatables.net package and a bunch of its support packages. Earlier this year I introduce a new extension for DataTables called "ColumnControl" (full details in the blog post here). It would be great if you were able to add have this on CDNJS as well.

More generally, you have a lot of the DataTables extensions and styling support packages, but it is not complete. Would you accept a PR to include all of them? I know you have a requirement to have a certain number of npm installs per month, and some of the lesser used styling packages won't met that requirement, but is would allow all combinations of DataTables, its extensions and styles to be used via CDNJS.

Also adds the styling support libraries for this package
@MattIPv4
Copy link
Member

More generally, you have a lot of the DataTables extensions and styling support packages, but it is not complete. Would you accept a PR to include all of them?

Yes, feel free to open a PR (or multiple) to add ones that're missing, happy to consider them all part of DataTables overall popularity.

@MattIPv4 MattIPv4 changed the title Add datatables.net-columncontrol w/ npm autoupdate Add datatables.net-columncontrol{,-*} w/ npm auto-update Aug 15, 2025
@AllanJard
Copy link
Contributor Author

That's awesome - thank you! I'll build a little script to get that done once this PR is ready to land.

I'm not sure why it is failing at the moment. The test runner says:

Filename js/columnControl.bulma.min.js not found in most recent version 1.0.7.

This is for the package datatables.net-columncontrol-bm, However, npm have the file in 1.0.7. If I npm i the package, I can see it there, and it is in the github repo.

I don't think it is something simple like a case error, the file does appear to be present. Any idea what might be causing the error?

@MattIPv4
Copy link
Member

You've got basePath set in the config, so we're pulling the files up and out of that path to the root. So, you don't need the js/ prefix.

@AllanJard
Copy link
Contributor Author

Ah!! Many thanks for spotting that. I've corrected that now for all of the datatables.net-columncontrol* packages. I'll keep an eye on the test runner results.

@MattIPv4 MattIPv4 merged commit a5d9687 into cdnjs:master Sep 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants