improve GC behavior for UGens; fix SndBuf FD cleanup #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) remove the special case of shreds remembering/ref-counting UGens created therein 2) remove all reference counting from UGen connection => and =^ 3) depend on the normal garbage collection to clean up UGen references in the code 4) when UGen variables go out of scope (and refcount goes to 0), also disconnect itself from the UGen graph
nshaheed
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now UGens are garbage collected and disconnected from all its UGen onnections, as soon as it is now longer referenced from code (previously, this was deferred until the end of origin shred the UGen was created on, which poses potentially significant memory build-up if a shred repeatedly instantiated/connected UGens without exiting). Overall, this internal update should result in improved CPU performance and memory behavior in various scenarios.