added channel voice message to MidiOut #451
Merged
+272
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewang
approved these changes
Jul 10, 2024
thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose channel voice messages on MidiOut for convenience.
Midi channel is not one-based, that's probably how it's expected from the user's perspective, happy to change though.
The two-byte MidiOut::send version was modified to fix a faulty behaviour on macOS. This could be a breaking change, but it's improbable and from what i could tell, this function was unused anyway, so it should be fine.
Will open another PR on chuck-website updating the docs after review changes and merge :)