Changed NSNumber to NSDecimalNumber when retrieving doubles from db#322
Open
rafek wants to merge 1 commit intoccgus:masterfrom
Open
Changed NSNumber to NSDecimalNumber when retrieving doubles from db#322rafek wants to merge 1 commit intoccgus:masterfrom
rafek wants to merge 1 commit intoccgus:masterfrom
Conversation
…as this allows for a better precision
Owner
|
Thanks for doing this. I don't want to change the behavior for a 2.x update of FMDB though- and swapping out classes behind the scenes does that. So, maybe for the next big release (3.0?) I'll add this in. Do you have any tests where you can show NSNumber not being precise enough by any chance? If I can test and reproduce a failure, it's more likely to get added. |
|
I had a decimal precision problem, the column type I got is real. I patched by using this code: |
|
I would like to vote up this request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow for better precision = less rounding errors.