Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch_prox should check against actual Koha record #10

Closed
phette23 opened this issue Sep 5, 2023 · 0 comments
Closed

patch_prox should check against actual Koha record #10

phette23 opened this issue Sep 5, 2023 · 0 comments
Assignees

Comments

@phette23
Copy link
Member

phette23 commented Sep 5, 2023

It seems like many students, while their prox numbers haven't changed across multiple prox reports, still don't have them in Koha. But the way the patch_prox_num script works is, to minimize HTTP requests, we just check against the most recent prox report and the last one we have on disk and only consider it a "changed" number if there's a difference there. There seem to be many situations where a student record is created or otherwise update such that their prox falls out of date but the script doesn't catch the change.

Paul sent me a couple example students to work with today. One still has their old cardnumber (not prox) so that should be a good test. We need the script to actually pull the Koha record, check for a prox num difference, and make an update if so. We can get rid of the code that compares a past prox report to the current one.

@phette23 phette23 self-assigned this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant