Skip to content

Cache proactive auth refresh fallback#210

Closed
cbusillo wants to merge 2 commits into
mainfrom
fix/cache-auth-refresh-fallback
Closed

Cache proactive auth refresh fallback#210
cbusillo wants to merge 2 commits into
mainfrom
fix/cache-auth-refresh-fallback

Conversation

@cbusillo
Copy link
Copy Markdown
Owner

Summary

  • record a cooldown when proactive ChatGPT token refresh fails but the cached access token is still valid
  • keep expired tokens forcing refresh instead of falling back
  • cover the retry-suppression behavior so immediate callers do not repeatedly hit the refresh endpoint during outages

Validation

  • cargo test -p code-core proactive_refresh --lib
  • cargo test -p code-core auth_for_stored_account --lib
  • ./build-fast.sh

@shiny-code-bot
Copy link
Copy Markdown
Collaborator

shiny-code-bot commented May 30, 2026

Closing this PR as superseded by #223.

The auth fallback behavior from this PR was already landed in the refined replacement PR #223 (fix(core): cool down proactive auth refresh fallback). #223 keeps the useful cooldown behavior, adds the safer stored-account update_account_last_refresh path so fallback does not duplicate accounts, and is already merged into main.

@shiny-code-bot shiny-code-bot deleted the fix/cache-auth-refresh-fallback branch May 30, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants