Skip to content

Fix rebuild helper external target release path #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbusillo merged 1 commit into from
May 27, 2026
Merged

Fix rebuild helper external target release path #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion scripts/local/rebuild-path-code.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ set -euo pipefail
repo_root="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
code_rs_root="$repo_root/code-rs"
release_bin="$code_rs_root/target/release/code"
cargo_target_dir="${CARGO_TARGET_DIR:-$code_rs_root/target}"
if [[ "$cargo_target_dir" != /* ]]; then
cargo_target_dir="$(pwd)/$cargo_target_dir"
fi
cargo_release_bin="$cargo_target_dir/release/code"

resolve_code_version() {
node -p "require('$repo_root/codex-cli/package.json').version"
Expand Down Expand Up @@ -38,6 +43,13 @@ else
fi
trap - EXIT

if [[ "$cargo_release_bin" != "$release_bin" ]]; then
mkdir -p "$(dirname "$release_bin")"
rm -f "$release_bin"
ln -s "$cargo_release_bin" "$release_bin"
echo "Updated release-bin symlink for external target dir: $release_bin -> $cargo_release_bin"
fi

path_code="$(command -v code || true)"
if [[ -z "$path_code" ]]; then
echo "error: could not find 'code' on PATH" >&2
Expand All @@ -50,13 +62,19 @@ import os, sys
print(os.path.realpath(sys.argv[1]))
PY
)"
resolved_release_bin="$(
python3 - "$release_bin" <<'PY'
import os, sys
print(os.path.realpath(sys.argv[1]))
PY
)"

echo
echo "PATH entry: $path_code"
echo "Resolves to: $resolved_path"
echo "Release bin: $release_bin"

if [[ "$resolved_path" != "$release_bin" ]]; then
if [[ "$resolved_path" != "$release_bin" && "$resolved_path" != "$resolved_release_bin" ]]; then
echo "warning: PATH does not resolve to the freshly built binary" >&2
fi

Expand Down