Add strict null checking **DRAFT**

.editorconfig

@@ -0,0 +1,20 @@
+# EditorConfig is awesome: https://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+# Unix-style newlines with a newline ending every file
+[*]
+end_of_line = lf
+insert_final_newline = true
+
+[*.{json,md,yml}]
+indent_style = space
+indent_size = 2
+
+[*.{ts,js}]
+indent_style = space
+indent_size = 4
+
+[Makefile]
+indent_style = tab

.github/workflows/pr.yml

@@ -1,62 +1,83 @@
+name: Static Checks
+
 on: pull_request
-name: Pull request
+
 jobs:
+  lint:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: [12.x]
+    steps:
+      - uses: actions/checkout@v3
+      - name: Install Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+      - uses: actions/cache@v3
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+      - run: npm ci
+      - run: npm run lint-check-only
   test:
     runs-on: ubuntu-latest
     strategy:
       matrix:
         node-version: [12.x]
     steps:
-    - uses: actions/checkout@v2
-    - name: Install Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v1
-      with:
-        node-version: ${{ matrix.node-version }}
-    - uses: actions/cache@v2
-      id: npm-cache
-      with:
-        path: ~/.npm
-        key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
-        restore-keys: |
-          ${{ runner.os }}-node-
-    - run: npm ci
-    - run: npm run test
+      - uses: actions/checkout@v3
+      - name: Install Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+      - uses: actions/cache@v3
+        id: npm-cache
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+      - run: npm ci
+      - run: npm run test
   build:
     runs-on: ubuntu-latest
     strategy:
       matrix:
         node-version: [12.x]
     steps:
-    - uses: actions/checkout@v2
-    - name: Install Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v1
-      with:
-        node-version: ${{ matrix.node-version }}
-    - uses: actions/cache@v2
-      with:
-        path: ~/.npm
-        key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
-        restore-keys: |
-          ${{ runner.os }}-node-
-    - run: npm ci
-    - run: npm run lint
+      - uses: actions/checkout@v3
+      - name: Install Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+      - uses: actions/cache@v3
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+      - run: npm ci
+      - run: npm run lint
   docs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
         node-version: [12.x]
     steps:
-    - uses: actions/checkout@v2
-    - name: Install Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v1
-      with:
-        node-version: ${{ matrix.node-version }}
-    - uses: actions/cache@v2
-      with:
-        path: ~/.npm
-        key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
-        restore-keys: |
-          ${{ runner.os }}-node-
-    - run: npm ci
-    - run: npm run build:doc
-    - run: git diff-files --ignore-all-space --name-only --exit-code
+      - uses: actions/checkout@v2
+      - name: Install Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+      - uses: actions/cache@v3
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+      - run: npm ci
+      - run: npm run build:doc
+      - run: git diff-files --ignore-all-space --name-only --exit-code

.prettierrc.js

@@ -1,20 +1,6 @@
 module.exports = {
-    printWidth: 80,
-    semi: false,
-    trailingComma: "all",
-    tabWidth: 4,
-    overrides: [
-        {
-            files: ["*.json"],
-            options: {
-                tabWidth: 2,
-            },
-        },
-        {
-            files: "*.md",
-            options: {
-                tabWidth: 2,
-            },
-        },
-    ],
+  printWidth: 80,
+  semi: false,
+  trailingComma: "all",
+  editorConfig: true,
 }

CHANGELOG.md

@@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [next] - TBD
 
+## [4.5.0] - TBD
+
+### Changed
+
+- Enable TypeScript strict null checks.
+- Avoid fetching if caller doesn't provide Window dependency.
+
+### Security
+
+- Address security alery: [Inefficient Regular Expression Complexity in moment](https://github.com/cbsinteractive/openinsights/security/dependabot/21)
+
 ## [4.4.1] - 2022-07-21
 
 ### Security

package.json

@@ -16,8 +16,8 @@
     "build": "tsc --build",
     "build:doc": "rimraf doc && typedoc src/index.ts",
     "build:release": "rimraf dist && rollup -c",
-    "lint": "tsc && eslint --fix 'src/**'",
-    "lint-check-only": "tsc && eslint 'src/**'",
+    "lint": "tsc --noEmit --strictNullChecks && eslint --fix 'src/**'",
+    "lint-check-only": "tsc --noEmit --strictNullChecks && eslint 'src/**'",
     "test": "jest --coverage",
     "test:debug": "node --inspect-brk node_modules/.bin/jest --runInBand",
     "prepublishOnly": "npm run build:release"

src/lib/errors.ts

@@ -19,3 +19,10 @@ export enum KnownErrors {
      */
     TestExecution,
 }
+
+export class WindowUndefinedError extends Error {
+    constructor(label: string) {
+        super(`Window undefined (${label})`)
+        Object.setPrototypeOf(this, new.target.prototype)
+    }
+}

src/lib/fetch.ts

@@ -1,4 +1,5 @@
 import { BeaconHandler } from "../util/beaconHandler"
+import { WindowUndefinedError } from "./errors"
 import { asyncGetEntry } from "./resourceTiming"
 import { Test } from "./test"
 
@@ -21,7 +22,7 @@ export interface FetchTestResultBundle {
 }
 
 export interface Dependencies {
-    window: Window & typeof globalThis
+    window: (Window & typeof globalThis) | undefined
 }
 
 /**
@@ -116,6 +117,9 @@ export abstract class Fetch<
      */
     test(): Promise<void> {
         const defaultTimeout = 5000
+        if (!this._deps.window) {
+            return this.onError(new WindowUndefinedError("Fetch.test"))
+        }
         return Promise.all([
             this.fetchObject(),
             asyncGetEntry(