Add support for cargo bench (Fixes #9) #12
Conversation
This should fix the issue at hand but I might have killed some corner cases. I deleted some error messages which don't look as if they were actually sound anyways.
| [] => Err(err_msg("No suitable build artifacts found.")), | ||
| [the_one] => Ok(the_one), | ||
| the_many => Err(format_err!( | ||
| "Found several artifact candidates: \n :{:?}", |
There was a problem hiding this comment.
I think we should still print an error messages which suggests ways to solve the error (when many artifacts are found). E.g "Please use --test [...]".
There was a problem hiding this comment.
I am out of time for today, but will look into this in the next few days
|
We should probably also add some info about this in the README |
|
Thanks already, I'm out of time for today, but will take a closer look at those |
|
@cbourjau thanks for doing this! This will be very helpful to many of us hoping to integrate cargo bench with other profiling tools. |
|
@cbourjau if you want we could merge this now and I could fix up the error message in a separate PR? I fully understand that you have other things which take time. As I currently have some available time, I wouldn't mind doing it. 😊 |
|
Yes, please go ahead! Thanks a lot!
Ole Martin Ruud writes:
… @cbourjau if you want we could merge this now and I could fix up the error message in a separate PR? I fully understand that you have other
things which take time. As I currently have some available time, I wouldn't mind doing it. 😊
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
--
Christian Bourjau
+45 915 666 01 | [email protected]
LinkedIn: http://se.linkedin.com/pub/christian-bourjau/93/888/77/
|
This should fix the issue at hand but I might have killed some corner
cases. I deleted some error messages which don't look as if they were
actually sound anyways. What do you think, @barskern ?