...

cboettig · Apr 8, 2024 · 139ec96 · 139ec96
1 parent ee424b3
commit 139ec96
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 13 deletions.
diff --git a/tests/testthat.R b/tests/testthat.R
@@ -9,19 +9,7 @@
 library(testthat)
 library(duckdbfs)
 
-mc_config_get <- function(alias="play"){
 
-  # this can fail tp parse on windows, stdout is not pure json
-  # p <- minioclient::mc_alias_ls(paste(alias, "--json"))
-  # config <- jsonlite::fromJSON(p$stdout)
-
-  path <- getOption("minioclient.dir", tools::R_user_dir("minioclient", "data"))
-  json <- jsonlite::read_json(file.path(path, "config.json"))
-  config <- json$aliases[[alias]]
-  config$alias <- alias
-  config$URL <- config$url
-  config
-}
 
 
 test_check("duckdbfs")
diff --git a/tests/testthat/test-write_dataset.R b/tests/testthat/test-write_dataset.R
@@ -77,7 +77,8 @@ test_that("write_dataset to s3:", {
   skip_if_not_installed("minioclient")
   minioclient::install_mc(force = TRUE)
 
-  config <- mc_config_get("play")
+  p <- minioclient::mc_alias_ls(paste(alias, "--json"))
+  config <- jsonlite::fromJSON(p$stdout)
 
   minioclient::mc_mb("play/duckdbfs")
   mtcars |> dplyr::group_by(cyl, gear) |>
@@ -95,4 +96,19 @@ test_that("write_dataset to s3:", {
 
 })
 
+mc_config_get <- function(alias="play"){
+
+  # this can fail tp parse on windows, stdout is not pure json
+  # p <- minioclient::mc_alias_ls(paste(alias, "--json"))
+  # config <- jsonlite::fromJSON(p$stdout)
+
+  ## fails to find config on remote
+  path <- getOption("minioclient.dir", tools::R_user_dir("minioclient", "data"))
+  json <- jsonlite::read_json(file.path(path, "config.json"))
+  config <- json$aliases[[alias]]
+  config$alias <- alias
+  config$URL <- config$url
+  config
+}
+