Discuss merging redesign #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5dc49fb.
cben
added a commit
that referenced
this pull request
May 25, 2015
…der. The header is using default browser fonts, which was OK but with [New document] now being a button it got different font from the other links. Experimented with same serif fonts as the editor but felt sans-serif is better; looked at rhythmus's redesign #45 which uses sans and stole his fonts. [Reminder to self: stop goofing around adding bugs and merge most of his design.] Also improved vertical centering of header (the float: right half was really off in firefox). Used simplest height = line-height technique (http://stackoverflow.com/a/8865463/239657) which is not fully robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rhythmus
This is a dummy pull-req I'm opening to myself, although I'm not yet able to merge it as is.
This looks gorgeous!
And the amount of work you did in one day is unbelievable. It would take me longer to even read through your changes :-)
I'm going to be quite busy in the next 3 weeks (moving countries, paper deadline) but I absolutely want to merge parts of this...
A few blockers I immediately see:
I'd like to experiment with changing formatting opacity from well visible during edit mode to faded out when clicking or just moving mouse outside (cf. https://hackpad.com/Introducing-Reading-mode-OI5XL2pSgjk).
Clear view of the source is IMHO crucial, especially for people who're new to markdown.
I've commented on some things in http://rhythmus.be/mathdown/?doc=DCJtdsxteYC#Mathdown-Bugs
I don't think CM is as bad as you describe, but we'll have to try other approaches. E.g. moving things to margins may be doable simply by giving bigger padding-left to normal text.
P.S. note that storing the documents in firebase means that http://mathdown.net/?doc=about and http://rhythmus.be/mathdown/?doc=about edit the very same document. (Which IMHO is really cool for open source services, one can fork and change the UI without any export-import dance...)
So I changed the description back to refer to "New document button (top right)" so (the rare) visitors to mathdown.net won't be confused by "file icon" reference.
(I should add a view mode taking docs like the landing page and Help from the source; allowing anybody to edit them is sometimes amusing but won't scale...)
Re font choice (as you are an expert): would you recommend Computer Modern as main editing font, or was it just proof-of-concept? What about users who don't need math and never saw LaTeX? What do you think of other fonts mathjax 2.3 supports e.g. Neo Euler?