fix: don't close file if create failed (influxdata#24366)

cbainlive · Sep 29, 2023 · 741e73d · 741e73d
1 parent 26afe43
commit 741e73d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/cmd/influxd/inspect/type_conflicts/schema.go b/cmd/influxd/inspect/type_conflicts/schema.go
@@ -125,10 +125,10 @@ func (s Schema) WriteConflictsFile(filename string) error {
 
 func (s Schema) encodeSchema(filename string) (rErr error) {
 	schemaFile, err := os.Create(filename)
-	defer errors2.Capture(&rErr, schemaFile.Close)()
 	if err != nil {
 		return fmt.Errorf("unable to create schema file: %w", err)
 	}
+	defer errors2.Capture(&rErr, schemaFile.Close)()
 	return s.Encode(schemaFile)
 }