Skip to content

Adds webpack 5 fix #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
byron-roots wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds webpack 5 fix #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84677a3
Ignroes ide files from git
byron-roots Jul 16, 2021
24c37ea
Update for compatability with webpack 5
byron-roots Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
logs
*.log
npm-debug.log*
.DS_Store
.idea

# Runtime data
pids
Expand Down
74 changes: 40 additions & 34 deletions styleguide-webpack-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,47 +21,53 @@ function StyleguideWebpackPlugin (options) {
StyleguideWebpackPlugin.prototype.apply = function (compiler) {
const self = this;

compiler.plugin('after-emit', function (compilation, callback) {
// Reset the asset arrays.
self.webpackCss = [];
self.webpackJs = [];
compiler.hooks.afterEmit.tapAsync(
{
name: 'Compile Stylguide',
}, function (compilation, callback) {
// Reset the asset arrays.
self.webpackCss = [];
self.webpackJs = [];

for (const filename in compilation.assets) {
const assetPath = '../' + filename;
// TODO find best way to determine order of assets from webpack.
for (const filename in compilation.assets) {
const assetPath = '../' + filename;
// TODO find best way to determine order of assets from webpack.

if (/\.js$/.test(filename)) {
// JS file.
if (!self.webpackJs.includes(assetPath)) {
if (/hot-update\.js/.test(filename)) {
// Place hot-update last.
self.webpackJs.push(assetPath);
} else {
self.webpackJs.unshift(assetPath);
if (/\.js$/.test(filename)) {
// JS file.
if (!self.webpackJs.includes(assetPath)) {
if (/hot-update\.js/.test(filename)) {
// Place hot-update last.
self.webpackJs.push(assetPath);
} else {
self.webpackJs.unshift(assetPath);
}
}
} else if (/\.css$/.test(filename)) {
// CSS file.
if (!self.webpackCss.includes(assetPath)) {
self.webpackCss.unshift(assetPath);
}
}
}
} else if (/\.css$/.test(filename)) {
// CSS file.
if (!self.webpackCss.includes(assetPath)) {
self.webpackCss.unshift(assetPath);
}
}
}

callback();
});
callback();
});

compiler.plugin('done', function () {
self.options.css = self.options.css || [];
self.options.js = self.options.js || [];
// Add the webpack assets.
const kssOptions = Object.assign({}, self.options, {
css: self.options.css.concat(self.webpackCss),
js: self.options.js.concat(self.webpackJs)
});
compiler.hooks.done.tapAsync(
{
name: 'Finish Stylguide',
}, function () {
self.options.css = self.options.css || [];
self.options.js = self.options.js || [];
// Add the webpack assets.
const kssOptions = Object.assign({}, self.options, {
css: self.options.css.concat(self.webpackCss),
js: self.options.js.concat(self.webpackJs)
});

kss(kssOptions);
});
kss(kssOptions);
});
};

module.exports = StyleguideWebpackPlugin;