Skip to content

Marshaling intermediary relationships in nested includes and using the driver where appropriate #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

cmanallen
Copy link
Contributor

@cmanallen cmanallen commented May 26, 2016

What does this pull request do?

Marshaling intermediary relationships in nested includes and using the driver where appropriate.

What are the relevant issues?

N/A

Any background context you want to provide?

I branched off the pagination branch for a Caxiam specific project. The diff is dirty but once the pagination branch is merged the changes will be much more clear.

Definition of Done:

Each should be selected to indicate consideration for applicability and/or completion.

  • Does this PR fully satisfy the scope as outlined in the referenced issue(s)?
  • Is there appropriate test coverage?
  • Is static analysis resulting in a satisfactory score?
  • If adding new dependencies, does pip requirements need to be updated?
  • Has the change log been updated?


@property
def strategy_cursor(self):
"""Return the valid keys for a cusor based strategy.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmanallen Minor typo.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.04%) to 94.786% when pulling 76e4854 on include into a3ab870 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 95.122% when pulling 1b3841a on include into a3ab870 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.04%) to 94.786% when pulling e544654 on include into a3ab870 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 94.747% when pulling 227e934 on include into a3ab870 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants