fix(github): dark theme header #1922
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncenter
reviewed
Sep 20, 2025
|
Some unthemed/bad contrast areas with prefers-color-mode: light: 
|
- HeaderMenu fixed in light & dark modes - Preferences button fixed in light mode - Removed unnecessary logged out header
LastElaphine
commented
Sep 20, 2025
| --fgColor-default: @text; | ||
| --fgColor-muted: @subtext1; | ||
| --fgColor-onEmphasis: @base; | ||
| --fgColor-white: if(@flavor = latte, @crust, @text); |
There was a problem hiding this comment.
I didn't notice any difference changing this logged in or out on a few different pages, so I'm not sure if it's still relevant to have it set to @crust on latte.
There was a problem hiding this comment.
I found one issue this was causing, currently the "Appearance Settings" icon in the top right in Latte is not visible:
But removing the if condition fixes it to look like this:
With the removal of the header overrides in this PR the text is not visible in Latte when the if condition is set:
Will all the changes in the PR it also looks correct on Latte:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 What does this fix? 🔧
Re-applies dark flavor styles to the header element in the specific case where the system is in dark mode with dark flavor is used. Other theme combinations continue to inherit styles normally.
Closes #1849
Verified the following combinations work as expected:
🗒 Checklist 🗒