Skip to content

Conversation

uncenter
Copy link
Member

@uncenter uncenter commented Sep 8, 2025

Integrates the new library module for MediaWiki sites from #1866. Must be merged after #1866 is merged into main.

@github-actions github-actions bot added the wiki.nixos.org NixOS Wiki label Sep 8, 2025
@uncenter uncenter changed the title feat(lib): add mediawiki lib module refactor(wiki.nixos.org): use mediawiki lib module Sep 8, 2025
@uncenter uncenter changed the title refactor(wiki.nixos.org): use mediawiki lib module refactor(wiki.nixos.org): use mediawiki library module Sep 8, 2025
@uncenter uncenter marked this pull request as ready for review September 8, 2025 01:37
@uncenter uncenter requested a review from orangci as a code owner September 8, 2025 01:37
@uncenter
Copy link
Member Author

uncenter commented Sep 8, 2025

@orangci I'd love if you could take a quick look and see if anything is broken. If things look good for the most part I'm going to merge #1866 before rebasing this one and merging it. Just don't merge it yourself yet :)

Copy link
Member

@orangci orangci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using https://raw.githubusercontent.com/catppuccin/userstyles/b9a7bb8e6ad1d8c11f174afbe4e8394f60bd0eb3/lib/mediawiki.less as the import instead of using https://userstyles.catppuccin.com/lib/mediawiki.less, as that doesn't exist (yet).

Works excellently! Great work on #1866.

I did notice that table cells don't seem to have proper borders.
For an example of this visit https://wiki.nixos.org/wiki/Terms_and_Definitions_in_Nix_Project and try toggling the userstyle off and on.

@uncenter
Copy link
Member Author

uncenter commented Sep 8, 2025

Tested using b9a7bb8/lib/mediawiki.less (raw) as the import instead of using userstyles.catppuccin.com/lib/mediawiki.less, as that doesn't exist (yet).

Oops yeah sorry I forgot to mention that, you figured it out anyway ahah.

I did notice that table cells don't seem to have proper borders.
For an example of this visit wiki.nixos.org/wiki/Terms_and_Definitions_in_Nix_Project and try toggling the userstyle off and on.

Thanks. I've adjusted border colors more and I think it's better: a6eda7e (#1866).

@orangci
Copy link
Member

orangci commented Sep 9, 2025

Thanks. I've adjusted border colors more and I think it's better: a6eda7e (#1866).

Yep, this is definitely better. I think this PR is now ready to merge as soon as #1866 is merged. 🧡

@uncenter uncenter linked an issue Oct 7, 2025 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wiki.nixos.org NixOS Wiki

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nix Wiki colors mismatch,

2 participants