Skip to content

refactor(google-drive): integrate m3 lib #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: feat/m3-lib
Choose a base branch
from
Open

refactor(google-drive): integrate m3 lib #1887

wants to merge 25 commits into from

Conversation

WalkQuackBack
Copy link
Member

Integrate M3 library module into Google Drive.

@WalkQuackBack WalkQuackBack changed the base branch from main to feat/m3-lib September 6, 2025 04:45
@github-actions github-actions bot added the google-drive Google Drive label Sep 6, 2025
@WalkQuackBack WalkQuackBack marked this pull request as ready for review September 6, 2025 05:21
WalkQuackBack
WalkQuackBack commented Sep 6, 2025
View reviewed changes
WalkQuackBack
WalkQuackBack commented Sep 6, 2025
View reviewed changes
@uncenter uncenter added the waiting on author Note for staff that a re-review is not yet required label Sep 7, 2025
r58Playz
r58Playz approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@r58Playz r58Playz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though only the video player's loading progress is themed for me. The other video player elements look like they're hardcoded

@WalkQuackBack
Copy link
Member Author

Looks good, though only the video player's loading progress is themed for me. The other video player elements look like they're hardcoded

Ah, missed that. I'll see if I can theme them without using too many generated classes.

@WalkQuackBack
Copy link
Member Author

Themed video player. Accidentally hit enter too early on the keyboard, whoops.

uncenter
uncenter reviewed Sep 9, 2025
View reviewed changes
uncenter
uncenter reviewed Sep 10, 2025
View reviewed changes
@WalkQuackBack
Copy link
Member Author

Anything that still needs changing?

@uncenter uncenter removed the waiting on author Note for staff that a re-review is not yet required label Sep 18, 2025
@uncenter
Copy link
Member

Anything that still needs changing?

Lint failure is all. Then this is good to go for after M3 lib module is merged.

@uncenter
Copy link
Member

Still need to fix that (autofixable) lint error :)

@uncenter uncenter added the pending Pending due to internal discussion, planned website updates, etc. label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r58Playz r58Playz r58Playz approved these changes

@uncenter uncenter Awaiting requested review from uncenter

Assignees

No one assigned

Labels

google-drive Google Drive pending Pending due to internal discussion, planned website updates, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WalkQuackBack @uncenter @r58Playz