feat(setup): improve private status bar #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make 'c.colors.statusbar.private.bg' more distinctive from 'c.colors.statusbar.normal.bg' by using the darkest palet color. Bright colors are not used because they would make all other 'c.colors.statusbar' properties harder to read.
Using the same color for 'c.colors.statusbar.command.private.bg' and 'c.colors.statusbar.command.bg' assures coherence with other menus, like 'c.colors.completion.category.bg'. However, the overall coherence in private mode is improved by matching 'c.colors.statusbar.command.private.bg' with 'c.colors.statusbar.private.bg'.
trueNAHO
added a commit
to trueNAHO/qutebrowser
that referenced
this pull request
Aug 23, 2023
Merge branches 'feat-setup-improve-color-contrast' and 'feat-setup-improve-private-statusbar' into 'dev'. Addresses: - catppuccin#3 - catppuccin#4
trueNAHO
added a commit
to trueNAHO/dotfiles
that referenced
this pull request
Aug 27, 2023
Integrate PRs until upstream merges catppuccin/qutebrowser#3 and catppuccin/qutebrowser#4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.colors.statusbar.private.bgcolorc.colors.statusbar.private.bgmore distinctive fromc.colors.statusbar.normal.bgby using the darkest palet color. Bright colors are not used because they would make all otherc.colors.statusbarproperties harder to read.c.colors.statusbar.command.private.bgandc.colors.statusbar.command.bgassures coherence with other menus, likec.colors.completion.category.bg. However, the overall coherence in private mode is improved by matchingc.colors.statusbar.command.private.bgwithc.colors.statusbar.private.bg.