ci: merge patch workflows #921
Conversation
comfysage
changed the title
| docs: | ||
| name: generate vimdoc | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
I think you might still need into issues if you don't run these sequentially 🤔 I think it makes sense to generate the docs first and then put a needs: [docs] into the integration-table-gen job.
I'm aware that this is only a problem when someone edits the docs and edits an integration but running sequentially should be fine.
| branches: | ||
| - main |
There was a problem hiding this comment.
this should be deleted now - otherwise the pull_request event will never trigger
There was a problem hiding this comment.
That should be fine. That code is saying run on all pull requests to the main branch.
There was a problem hiding this comment.
really? i would think the opposite
There was a problem hiding this comment.
Yeah, usually I do this:
on:
workflow_dispatch:
push:
branches: [main]
pull_request:
branches: [main]Which translates into CI on any pushes to main, any pull requests to main and then workflow_dispatch for any manual invocations.
2 participants
No description provided.