Skip to content

Conversation

mrcjkb
Copy link

@mrcjkb mrcjkb commented Apr 18, 2024

Hey 👋

Summary

This PR is part of a push to get neovim plugins on luarocks.org.

See also:

Things done:

  • Add a workflow that generates a rockspec for Neovim plugins and publishes tags to luarocks.org when a tag or release is pushed.

I noticed there's an existing catppuccin luarock, but it cannot be used to set the Neovim colorscheme, as it is missing the rtp paths.

  • I've set the package name in the luarocks workflow to catppuccin.nvim.
  • It might be a good idea to add a section to the readme, telling rocks.nvim users to use :Rocks install catppuccin.nvim and not :Rocks install catppuccin?

Notes:

Important

  • For the luarocks workflow to work, someone with a luarocks.org account will have to add their API key to this repo's GitHub actions secrets.

  • As you use GitHub releases to create tags (with the release-please action), you may need to add a PA token for the workflow to be triggered automatically.

@rewhile rewhile mentioned this pull request May 20, 2024
4 tasks
@sgoudham sgoudham removed the blocked label Aug 1, 2025
@sgoudham
Copy link
Contributor

sgoudham commented Aug 2, 2025

Sorry for how long this PR has stalled @mrcjkb! We're finally in a position to upload plugins/packages to luarocks.

I've modified the CI to upload to luarocks as part of the release-please run.

I also believe rocks.nvim is no longer in development since this PR was raised, and it has shifted over to Lux? Would that be the recommendation in the README?

@mrcjkb
Copy link
Author

mrcjkb commented Aug 2, 2025

I also believe rocks.nvim is no longer in development since this PR was raised, and it has shifted over to Lux? Would that be the recommendation in the README?

Rocks.nvim is still maintained, but we will rename it to lux.nvim after we switch to using lux.
It's going to take some time before we complete the switch, so I would keep the readme example for now.

@sgoudham sgoudham added this to the v2.0.0 milestone Aug 3, 2025
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry again for how long this has taken, thanks for raising the initial PR.

We'll test this workflow out in our upcoming v2.0.0 release!

In the meantime, I'll upload our last release manually Nevermind, uploading manually seems to be a bit of a hassle 😄 Holding off merge until v2.0.0 is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants