feat!: Add support for CM6 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeMirror 6 changes from CSS to JavaScript stylesheets. This breaks compatiblity with CodeMirror 5. The new architecture is based on the one-dark example theme from the official CodeMirror repository. Fixes catppuccin#2
BuonOmo
commented
Mar 27, 2025
uncenter
suggested changes
Mar 27, 2025
package.json
Outdated
| "version": "6.0.0", | ||
| "description": "Catppuccin themes for the CodeMirror code editor", | ||
| "scripts": { | ||
| "test": "echo 'Life is beautiful.'", |
There was a problem hiding this comment.
Suggested change
| "test": "echo 'Life is beautiful.'", |
package.json
Outdated
Comment on lines
13
to
17
| "author": { | ||
| "name": "Ulysse Buonomo", | ||
| "email": "[email protected]", | ||
| "url": "https://ulysse.md" | ||
| }, |
There was a problem hiding this comment.
Suggested change
| "author": { | |
| "name": "Ulysse Buonomo", | |
| "email": "[email protected]", | |
| "url": "https://ulysse.md" | |
| }, | |
| "author": "Catppuccin Org <[email protected]>", |
|
@uncenter Thanks for the thorough review, would you mind reviewing the fixup commit? |
|
Hey 👋, I want to confirm that I will be looking at this, just been in other areas of the organisation as of late. Your work won't go unnoticed / stale ❤️ @BuonOmo |
sgoudham
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeMirror 6 changes from CSS to JavaScript stylesheets. This breaks compatiblity with CodeMirror 5. The new architecture is based on the one-dark example theme from the official CodeMirror repository.
Fixes #2