This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Fixed some warnings + added new warnings for unit tests#83
Open
n3rdswithgame wants to merge 3 commits intocatchorg:masterfrom
Open
Fixed some warnings + added new warnings for unit tests#83n3rdswithgame wants to merge 3 commits intocatchorg:masterfrom
n3rdswithgame wants to merge 3 commits intocatchorg:masterfrom
Conversation
fixed a -Wshadow warning on gcc by changing the names of the ctor arguments
fixed a -Wsign-conversion warning in gcc and clang by static casting the iterator difference to a size_t. The result should should always be >=0 so the static cast will just suppress the warning
Added some extra warnings to the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not really a major change, but it helps out for any project that tries to build without any warnings like I do.
Added
-Wshadowand-Wsign-conversionwarnings to the gcc + clang warnings for the test suite. GCC does not turn these on by default with-Wallor-Wextra, and I don't know if clang bundles them the added warnings in its-Wallor-Wextra.Also fixed a few lines in the headers that raised these warnings, namely appending an underscore for the shadow warning and a static cast to the sign conversion warning. I went with the underscore on the arguments as I figured there was a good reason that the
TokenStream::itandTokenStream::itEndmembers didn't have anm_prefix.