Skip to content

Conversation

@bwalkerl
Copy link
Contributor

@bwalkerl bwalkerl commented Jul 18, 2025

Partial unit test fixes for t19 that are simple and universal.

  • PHPUnit 10+: Requires data providers to be static. - but this is a safe change for all versions
  • Totara expects unit test classes formatted a specific way. This doesn't fully address that as it may require flattening the structure and would be better suited for a branch with all T19 fixes. Instead, this just resolves the phpunit warning for "Class cleaner_test cannot be found" - which relies on the filename being in the class name.

Fixes for other breaking changes are likely better on a new branch.

@djarran
Copy link

djarran commented Jul 18, 2025

Looks good, merging

@djarran djarran merged commit 72dcae5 into TOTARA_13 Jul 18, 2025
20 checks passed
@djarran djarran deleted the totara-unit-test-fixes branch July 18, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants