Repository navigation
Feature: Add IDP Response Signing Capabilities - #973
Open
jakobsyvertsen wants to merge 4 commits into
Open
jakobsyvertsen wants to merge 4 commits into
jakobsyvertsen wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst this plugin has added IDP capabilities, it currently lacks a method to sign responses to SPs. This can be a problem when an SP expects responses to be signed, and is generally better for security overall.
This pull request very simply adds a toggle to the plugin settings page asking if you want to sign your responses, along with using the pre-existing assertion signing framework to also sign the response if the option is selected.